Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust theming documentation #582

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Conversation

Prokyonn
Copy link
Member

Q A
Fixed tickets fixes #issuenum
Related PRs sulu/sulu#prnum
License MIT

What's in this PR?

Removes the documentation about the SuluThemeBundle and adds a reference to the real bundle documentation.

Why?

Because all the other bundles also have their own documentation in the bundle repository and not in the core documentation.

Only merge this PR after sulu/SuluThemeBundle#19 is merged!

@Prokyonn Prokyonn force-pushed the enhancement/theme branch 2 times, most recently from 531b7ee to 698b763 Compare November 12, 2020 11:03
@niklasnatter
Copy link
Contributor

is this still WIP? 🙂

@niklasnatter
Copy link
Contributor

Also, think we should change the target branch to 2.1

@Prokyonn Prokyonn marked this pull request as ready for review November 19, 2020 13:30
@Prokyonn Prokyonn changed the base branch from master to 2.1 November 19, 2020 13:30
@Prokyonn Prokyonn changed the title WIP: Adjust theming documentation Adjust theming documentation Nov 19, 2020
@niklasnatter niklasnatter merged commit 4da14c2 into sulu:2.1 Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants