From 02cc5bafc551fafd76a4d981826fde2d4d11553e Mon Sep 17 00:00:00 2001 From: Ivan Maximov Date: Tue, 9 Jan 2024 10:38:55 +0300 Subject: [PATCH 1/8] Tune benchmarks --- .github/workflows/benchmarks.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index a6de5c3..52b8aff 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -1,3 +1,4 @@ +# https://github.com/benchmark-action/github-action-benchmark name: Continuous benchmarking on: pull_request: @@ -36,10 +37,11 @@ jobs: name: SteroidsDI Benchmarks tool: 'benchmarkdotnet' output-file-path: src/Benchmarks/BenchmarkDotNet.Artifacts/results/Combined.Benchmarks.json - github-token: ${{ secrets.GITHUB_TOKEN }} alert-threshold: '101%' comment-on-alert: true fail-on-alert: true + - name: AAA + run: echo 'https://${{ GITHUB_REPOSITORY_OWNER }}@sss' - name: Push benchmarks results if: github.event_name != 'pull_request' run: git push 'https://sungam3r:${{ secrets.GITHUB_TOKEN }}@github.com/sungam3r/SteroidsDI.git' gh-pages:gh-pages From d664d92e0acf186d6efbfee24809caed3ff18cf3 Mon Sep 17 00:00:00 2001 From: Ivan Maximov Date: Tue, 9 Jan 2024 10:45:39 +0300 Subject: [PATCH 2/8] 1 --- .github/workflows/benchmarks.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 52b8aff..391f16a 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -1,4 +1,3 @@ -# https://github.com/benchmark-action/github-action-benchmark name: Continuous benchmarking on: pull_request: From b3d029d531e363c1097ce71a76526fd26229cc1e Mon Sep 17 00:00:00 2001 From: Ivan Maximov Date: Tue, 9 Jan 2024 10:54:27 +0300 Subject: [PATCH 3/8] 1 --- .github/workflows/benchmarks.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 391f16a..fa25be9 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -1,3 +1,4 @@ +# https://github.com/benchmark-action/github-action-benchmark name: Continuous benchmarking on: pull_request: @@ -40,7 +41,7 @@ jobs: comment-on-alert: true fail-on-alert: true - name: AAA - run: echo 'https://${{ GITHUB_REPOSITORY_OWNER }}@sss' + run: echo 'https://$GITHUB_REPOSITORY_OWNER@sss' - name: Push benchmarks results if: github.event_name != 'pull_request' run: git push 'https://sungam3r:${{ secrets.GITHUB_TOKEN }}@github.com/sungam3r/SteroidsDI.git' gh-pages:gh-pages From 622c0739c4a64ff970d17c373c49e476659f1b2b Mon Sep 17 00:00:00 2001 From: Ivan Maximov Date: Tue, 9 Jan 2024 10:58:03 +0300 Subject: [PATCH 4/8] 1 --- .github/workflows/benchmarks.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index fa25be9..ce0f282 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -37,6 +37,7 @@ jobs: name: SteroidsDI Benchmarks tool: 'benchmarkdotnet' output-file-path: src/Benchmarks/BenchmarkDotNet.Artifacts/results/Combined.Benchmarks.json + github-token: ${{ secrets.GITHUB_TOKEN }} alert-threshold: '101%' comment-on-alert: true fail-on-alert: true @@ -44,4 +45,4 @@ jobs: run: echo 'https://$GITHUB_REPOSITORY_OWNER@sss' - name: Push benchmarks results if: github.event_name != 'pull_request' - run: git push 'https://sungam3r:${{ secrets.GITHUB_TOKEN }}@github.com/sungam3r/SteroidsDI.git' gh-pages:gh-pages + run: git push 'https://$GITHUB_REPOSITORY_OWNER:${{ secrets.GITHUB_TOKEN }}@github.com/$GITHUB_REPOSITORY.git' gh-pages:gh-pages From c2f7afcc08970b93e3d4b201ca985d5f192f0b9f Mon Sep 17 00:00:00 2001 From: Ivan Maximov Date: Tue, 9 Jan 2024 11:02:07 +0300 Subject: [PATCH 5/8] 1 --- .github/workflows/benchmarks.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index ce0f282..41ccc1e 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -40,7 +40,6 @@ jobs: github-token: ${{ secrets.GITHUB_TOKEN }} alert-threshold: '101%' comment-on-alert: true - fail-on-alert: true - name: AAA run: echo 'https://$GITHUB_REPOSITORY_OWNER@sss' - name: Push benchmarks results From d0d2db7b3ab2b65b87d63b84162f00f1df46c70a Mon Sep 17 00:00:00 2001 From: Ivan Maximov Date: Tue, 9 Jan 2024 11:12:15 +0300 Subject: [PATCH 6/8] 1 --- .github/workflows/benchmarks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 41ccc1e..38d14ad 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -41,7 +41,7 @@ jobs: alert-threshold: '101%' comment-on-alert: true - name: AAA - run: echo 'https://$GITHUB_REPOSITORY_OWNER@sss' + run: echo 'https://$GITHUB_REPOSITORY_OWNER@sss' && echo '${{ github.repository }} or ${{ github.repository_owner }}' - name: Push benchmarks results if: github.event_name != 'pull_request' run: git push 'https://$GITHUB_REPOSITORY_OWNER:${{ secrets.GITHUB_TOKEN }}@github.com/$GITHUB_REPOSITORY.git' gh-pages:gh-pages From 9fdee0397a84eeb556477366c9b3945f3d3bfe2b Mon Sep 17 00:00:00 2001 From: Ivan Maximov Date: Tue, 9 Jan 2024 11:18:30 +0300 Subject: [PATCH 7/8] 1 --- .github/workflows/benchmarks.yml | 4 +--- src/Benchmarks/DeferBenchmarks.cs | 2 ++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 38d14ad..09cda97 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -40,8 +40,6 @@ jobs: github-token: ${{ secrets.GITHUB_TOKEN }} alert-threshold: '101%' comment-on-alert: true - - name: AAA - run: echo 'https://$GITHUB_REPOSITORY_OWNER@sss' && echo '${{ github.repository }} or ${{ github.repository_owner }}' - name: Push benchmarks results if: github.event_name != 'pull_request' - run: git push 'https://$GITHUB_REPOSITORY_OWNER:${{ secrets.GITHUB_TOKEN }}@github.com/$GITHUB_REPOSITORY.git' gh-pages:gh-pages + run: git push 'https://${{ github.repository_owner }}:${{ secrets.GITHUB_TOKEN }}@github.com/${{ github.repository }}.git' gh-pages:gh-pages diff --git a/src/Benchmarks/DeferBenchmarks.cs b/src/Benchmarks/DeferBenchmarks.cs index ee5792a..1b9a828 100644 --- a/src/Benchmarks/DeferBenchmarks.cs +++ b/src/Benchmarks/DeferBenchmarks.cs @@ -28,6 +28,8 @@ public void Setup() public void ResolveDefer() { var defer = _provider.GetRequiredService>(); + for (int i = 0; i < 100; ++i) + ++i; _ = defer.Value; } From 9972a2af7567e3aa30e296b7725cee13ed9b9818 Mon Sep 17 00:00:00 2001 From: Ivan Maximov Date: Tue, 9 Jan 2024 11:30:25 +0300 Subject: [PATCH 8/8] 1 --- src/Benchmarks/DeferBenchmarks.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Benchmarks/DeferBenchmarks.cs b/src/Benchmarks/DeferBenchmarks.cs index 1b9a828..ee5792a 100644 --- a/src/Benchmarks/DeferBenchmarks.cs +++ b/src/Benchmarks/DeferBenchmarks.cs @@ -28,8 +28,6 @@ public void Setup() public void ResolveDefer() { var defer = _provider.GetRequiredService>(); - for (int i = 0; i < 100; ++i) - ++i; _ = defer.Value; }