increase min sunpy

[nabobalis]

This supersedes #48

• Fixes Add towncrier #49
• Renamed FortranTracer to PerformanceTracer
• Deprecated FortranTracer
• streamtracer is now a hard dep
• Deprecated bunch of utils I think we don't need anymore.
• Bunch of package updates
• Trying to tidy up the example gallery
• Adaptmap removed due to upstream support in sunpy

This turned into a large PR. I could split it out but i'm lazy.

[nabobalis]

I plan to add this to sunpy instead.

[Cadair]

Thanks @nabobalis

I think we need to be deprecating stuff, I made the first version 1.0.0 for a reason, I think stability is important here.

I will let @jgieseler and @STBadman chime in on things like load_adapt and fix_hmi_meta specifically, but I would like a review from at least one of them before we merge.

[nabobalis]

Not sure if we need this but it should be reference_date if we do.

[nabobalis]

I need to patch sunpy 6.0.0 first and then this should pass.

[nabobalis]

It is finally passing again with the fix from upstream.

[jgieseler]

I will let @jgieseler and @STBadman chime in on things like load_adapt and fix_hmi_meta specifically, but I would like a review from at least one of them before we merge.

Sorry for the delay, I'm buried in project work atm. 😬 I haven't ever used load_adapt, and fix_hmi_meta not in a long while, so maybe @STBadman can also give some input.

But I'm a bit confused regarding fix_hmi_meta. You state that it's deprecated because this is now fixed within sunpy when you load a HMI file. But if I download a HMI file (with files = Fido.fetch(...)) and then open it with hmi_map = sunpy.map.Map(files[0]), all the things fix_hmi_meta should fix are still in it, like hmi_map.meta['cunit2'] = 'Sine Latitude'. Am I doing it wrong?

[nabobalis]

But I'm a bit confused regarding fix_hmi_meta. You state that it's deprecated because this is now fixed within sunpy when you load a HMI file. But if I download a HMI file (with files = Fido.fetch(...)) and then open it with hmi_map = sunpy.map.Map(files[0]), all the things fix_hmi_meta should fix are still in it, like hmi_map.meta['cunit2'] = 'Sine Latitude'. Am I doing it wrong?

Oh in that case, I was very wrong and we should fix that in the map source.

The reason I said that was it was in the notes:

If you have sunpy > 2.1 installed, this function is not needed as sunpy
will automatically make these fixes.

But clearly I didn't check.

[jgieseler]

Yes, I saw that comment as well and was confused. That's why I was wondering if I do the loading in a wrong way.

[nabobalis]

Oh I am confused, sunpy doesn't change the meta anymore. If you access the attributes of the map, those should be correct now. I think .units?

[jgieseler]

Oh I am confused, sunpy doesn't change the meta anymore. If you access the attributes of the map, those should be correct now. I think .units?

Hm, I don't know. But I just checked and run some old code that uses fix_hmi_meta. I run it with applying fix_hmi_meta and also without (i.e., just loading the HMI file with sunpy). The resulting figures look the same, only in the latter case, some SunpyMetadataWarning are printed:

Missing metadata for solar radius: assuming the standard radius of the photosphere. [sunpy.map.mapbase]
2024-09-17 18:19:50 - sunpy - INFO: Missing metadata for solar radius: assuming the standard radius of the photosphere.
WARNING: SunpyMetadataWarning: Missing metadata for observer: assuming Earth-based observer.
For frame 'heliographic_stonyhurst' the following metadata is missing: hgln_obs,hglt_obs,dsun_obs
For frame 'heliographic_carrington' the following metadata is missing: crlt_obs,dsun_obs,crln_obs
 [sunpy.map.mapbase]
2024-09-17 18:19:50 - sunpy - WARNING: SunpyMetadataWarning: Missing metadata for observer: assuming Earth-based observer.
For frame 'heliographic_stonyhurst' the following metadata is missing: hgln_obs,hglt_obs,dsun_obs
For frame 'heliographic_carrington' the following metadata is missing: crlt_obs,dsun_obs,crln_obs

Fixed

[nabobalis]

Oh I am confused, sunpy doesn't change the meta anymore. If you access the attributes of the map, those should be correct now. I think .units?

Hm, I don't know. But I just checked and run some old code that uses fix_hmi_meta. I run it with applying fix_hmi_meta and also without (i.e., just loading the HMI file with sunpy). The resulting figures look the same, only in the latter case, some SunpyMetadataWarning are printed:

Missing metadata for solar radius: assuming the standard radius of the photosphere. [sunpy.map.mapbase]
2024-09-17 18:19:50 - sunpy - INFO: Missing metadata for solar radius: assuming the standard radius of the photosphere.
WARNING: SunpyMetadataWarning: Missing metadata for observer: assuming Earth-based observer.
For frame 'heliographic_stonyhurst' the following metadata is missing: hgln_obs,hglt_obs,dsun_obs
For frame 'heliographic_carrington' the following metadata is missing: crlt_obs,dsun_obs,crln_obs
 [sunpy.map.mapbase]
2024-09-17 18:19:50 - sunpy - WARNING: SunpyMetadataWarning: Missing metadata for observer: assuming Earth-based observer.
For frame 'heliographic_stonyhurst' the following metadata is missing: hgln_obs,hglt_obs,dsun_obs
For frame 'heliographic_carrington' the following metadata is missing: crlt_obs,dsun_obs,crln_obs

Ah I see, yeah but we should not be fixing these metadata ourselves but letting sunpy emit them. These are legit issues with the FITS files and having some special helper function for it is not something we should be doing in sunkit-magex.