Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetadataUriWrapper #138

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

MetadataUriWrapper #138

wants to merge 13 commits into from
+708 −54

Conversation

kimurayu45z
Copy link
Contributor

Overview

Base automatically changed from event to main November 22, 2024 06:25
kimurayu45z
kimurayu45z commented Nov 22, 2024
View reviewed changes
cmd/sunrised/cmd/config.go Outdated
shard_hashes_api = {{ .DA.ShardHashesAPI }}
# API to query DA v2 metadata
metadata_uri = {{ .DA.MetadataURI }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be metadata_api

@kimurayu45z
Copy link
Contributor Author

kimurayu45z commented Nov 22, 2024 •
edited
Loading

Sorry but it rather would be better to append only

message MetadataUriWrapper {
  string metadata_uri = 1;
}

to txs, than appending Metadata.
As I review this code, fetching metadata invites unreasonable overhead.

@kimurayu45z kimurayu45z changed the title comment MetadataUriWrapper Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimurayu45z @fantasyup