Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add verify token hash #328

Merged
merged 2 commits into from
Sep 22, 2023
Merged

fix: add verify token hash #328

merged 2 commits into from
Sep 22, 2023

Conversation

silentworks
Copy link
Contributor

What kind of change does this PR introduce?

This is the equivalent of supabase/auth-js#722 to make it easier to do fully server-side when double confirm is turned on for email confirmation.

@silentworks silentworks requested a review from J0 September 21, 2023 00:57
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14% 🎉

Comparison is base (cb6abab) 45.53% compared to head (82a04aa) 45.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   45.53%   45.67%   +0.14%     
==========================================
  Files          23       23              
  Lines        1893     1898       +5     
==========================================
+ Hits          862      867       +5     
  Misses       1031     1031              
Files Changed Coverage Δ
gotrue/types.py 99.03% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gotrue/types.py Show resolved Hide resolved
@J0
Copy link
Contributor

J0 commented Sep 21, 2023

Thanks for putting this together! Feel free to merge when ready

@silentworks silentworks merged commit ccb2173 into main Sep 22, 2023
12 checks passed
@silentworks silentworks deleted the feat/add-verify-token-hash branch September 22, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants