fix: add additional information around errors for missing content typ…

…e header (#1576) ## What kind of change does this PR introduce? Adds additional information around errors related to missing content-type headers so that developers can unblock themselves.
supabase · Sep 18, 2024 · c2b2f96 · c2b2f96
1 parent 25d9874
commit c2b2f96
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/internal/api/errorcodes.go b/internal/api/errorcodes.go
@@ -76,6 +76,7 @@ const (
 	ErrorCodeHookTimeout                       ErrorCode = "hook_timeout"
 	ErrorCodeHookTimeoutAfterRetry             ErrorCode = "hook_timeout_after_retry"
 	ErrorCodeHookPayloadOverSizeLimit          ErrorCode = "hook_payload_over_size_limit"
+	ErrorCodeHookPayloadInvalidContentType     ErrorCode = "hook_payload_invalid_content_type"
 	ErrorCodeRequestTimeout                    ErrorCode = "request_timeout"
 	ErrorCodeMFAPhoneEnrollDisabled            ErrorCode = "mfa_phone_enroll_not_enabled"
 	ErrorCodeMFAPhoneVerifyDisabled            ErrorCode = "mfa_phone_verify_not_enabled"

diff --git a/internal/api/hooks.go b/internal/api/hooks.go
@@ -137,18 +137,21 @@ func (a *API) runHTTPHook(r *http.Request, hookConfig conf.ExtensibilityPointCon
 		}
 
 		defer rsp.Body.Close()
-		// Header.Get is case insensitive
-		contentType := rsp.Header.Get("Content-Type")
-		mediaType, _, err := mime.ParseMediaType(contentType)
-		if err != nil {
-			return nil, internalServerError("Invalid Content-Type header")
-		}
-		if mediaType != "application/json" {
-			return nil, internalServerError("Invalid JSON response. Received content-type: " + contentType)
-		}
 
 		switch rsp.StatusCode {
 		case http.StatusOK, http.StatusNoContent, http.StatusAccepted:
+			// Header.Get is case insensitive
+			contentType := rsp.Header.Get("Content-Type")
+			if contentType == "" {
+				return nil, badRequestError(ErrorCodeHookPayloadInvalidContentType, "Invalid Content-Type: Missing Content-Type header")
+			}
+			mediaType, _, err := mime.ParseMediaType(contentType)
+			if err != nil {
+				return nil, badRequestError(ErrorCodeHookPayloadInvalidContentType, fmt.Sprintf("Invalid Content-Type header: %s", err.Error()))
+			}
+			if mediaType != "application/json" {
+				return nil, badRequestError(ErrorCodeHookPayloadInvalidContentType, "Invalid JSON response. Received content-type: "+contentType)
+			}
 			if rsp.Body == nil {
 				return nil, nil
 			}