Sending a magic link will sometimes fail due to password.Generate generating an invalid password #1761
Closed
2 tasks done
Labels
bug
Something isn't working
Comments
cstockton
added a commit
that referenced
this issue
Sep 24, 2024
## What kind of change does this PR introduce? Bug fix ## What is the current behavior? #1761 ## What is the new behavior? Now the password should generate secure enough with the necessary password requirements specified in environment variables. ## Additional context Basically this line in /internal/api/magic_link.go password.Generate(64, 10, 1, false, true) Generates an invalid value for this line in /internal/api/signup.go if err := a.checkPasswordStrength(ctx, p.Password); err != nil { --------- Co-authored-by: Chris Stockton <180184+cstockton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Describe the bug
Sending a magic link will sometimes fail due to
password.Generategenerating an invalid password that complies withcheckPasswordStrengthTo Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
Using Selfhosted Docker
GOTRUE_PASSWORD_REQUIRED_CHARACTERS: "!@#$%^&*()-_=+<>"to this value in environment under auth (or .env depending on how you are defining it)Expected behavior
The action should sucessfully send an email with a magic link to the user.
Screenshots
System information
Additional context
Basically this line in /internal/api/magic_link.go
password.Generate(64, 10, 1, false, true)Generates an invalid value for this line in /internal/api/signup.go
if err := a.checkPasswordStrength(ctx, p.Password); err != nil {The text was updated successfully, but these errors were encountered: