fix: magiclink failing due to passwordStrength check #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klajdi369
changed the title
klajdi369
force-pushed
the
fix-magiclink-requiredchars
branch
from
deb465d to
07a44bc
Compare
klajdi369
force-pushed
the
fix-magiclink-requiredchars
branch
from
999c09e to
fb1a58c
Compare
Pull Request Test Coverage Report for Build 11013705366Details
💛 - Coveralls |
cstockton
reviewed
Sep 17, 2024
|
@klajdi369 Want to address the comments so we merge this? |
Hi, yes, most likely will do within this week, as I have not had the time to get back to this PR. |
Co-authored-by: Chris Stockton <180184+cstockton@users.noreply.github.com>
klajdi369
force-pushed
the
fix-magiclink-requiredchars
branch
from
3bc0724 to
d2fe8f9
Compare
cstockton
approved these changes
Sep 24, 2024
kangmingtay
pushed a commit
that referenced
this pull request
Sep 27, 2024
🤖 I have created a release *beep* *boop* --- ## [2.162.0](v2.161.0...v2.162.0) (2024-09-27) ### Features * add support for migration of firebase scrypt passwords ([#1768](#1768)) ([ba00f75](ba00f75)) ### Bug Fixes * apply authorized email restriction to non-admin routes ([#1778](#1778)) ([1af203f](1af203f)) * magiclink failing due to passwordStrength check ([#1769](#1769)) ([7a5411f](7a5411f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
#1761
What is the new behavior?
Now the password should generate secure enough with the necessary password requirements specified in environment variables.
Additional context
Basically this line in /internal/api/magic_link.go
password.Generate(64, 10, 1, false, true)
Generates an invalid value for this line in /internal/api/signup.go
if err := a.checkPasswordStrength(ctx, p.Password); err != nil {