Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return validation failed error if captcha request was not json #1815

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

hf
Copy link
Contributor

@hf hf commented Oct 25, 2024

Returns HTTP 400 with the validation failed error code if the request body sent to the server when CAPTCHA verification is enabled was not JSON or couldn't be parsed into JSON.

@hf hf requested a review from a team as a code owner October 25, 2024 10:37
internal/api/middleware.go Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11516645394

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 57.165%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/middleware.go 0 3 0.0%
Totals Coverage Status
Change from base Build 11466551533: -0.007%
Covered Lines: 9574
Relevant Lines: 16748

💛 - Coveralls

@hf hf merged commit 26d2e36 into master Oct 25, 2024
3 checks passed
@hf hf deleted the hf/captcha-parsing-fix branch October 25, 2024 11:04
J0 pushed a commit that referenced this pull request Nov 15, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.164.0](v2.163.2...v2.164.0)
(2024-11-13)


### Features

* return validation failed error if captcha request was not json
([#1815](#1815))
([26d2e36](26d2e36))


### Bug Fixes

* add error codes to refresh token flow
([#1824](#1824))
([4614dc5](4614dc5))
* add test coverage for rate limits with 0 permitted events
([#1834](#1834))
([7c3cf26](7c3cf26))
* correct web authn aaguid column naming
([#1826](#1826))
([0a589d0](0a589d0))
* default to files:read scope for Figma provider
([#1831](#1831))
([9ce2857](9ce2857))
* improve error messaging for http hooks
([#1821](#1821))
([fa020d0](fa020d0))
* make drop_uniqueness_constraint_on_phone idempotent
([#1817](#1817))
([158e473](158e473))
* possible panic if refresh token has a null session_id
([#1822](#1822))
([a7129df](a7129df))
* rate limits of 0 take precedence over MAILER_AUTO_CONFIRM
([#1837](#1837))
([cb7894e](cb7894e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants