Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ip mismatch error message #1849

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

J0
Copy link
Contributor

@J0 J0 commented Nov 28, 2024

What kind of change does this PR introduce?

Response to an internal ticket, IP mismatch can show up when authenticating as well which might be confusing for users

@J0 J0 requested a review from a team as a code owner November 28, 2024 02:34
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12061486951

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.998%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/mfa.go 0 1 0.0%
Totals Coverage Status
Change from base Build 12045179447: 0.0%
Covered Lines: 9546
Relevant Lines: 16748

💛 - Coveralls

@J0 J0 merged commit 49fbbf0 into master Nov 28, 2024
3 checks passed
@J0 J0 deleted the j0/update_mfa_error_message branch November 28, 2024 15:46
cstockton pushed a commit that referenced this pull request Dec 5, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.165.0](v2.164.0...v2.165.0)
(2024-12-05)


### Features

* add email validation function to lower bounce rates
([#1845](#1845))
([2c291f0](2c291f0))
* use embedded migrations for `migrate` command
([#1843](#1843))
([e358da5](e358da5))


### Bug Fixes

* fallback on btree indexes when hash is unavailable
([#1856](#1856))
([b33bc31](b33bc31))
* return the error code instead of status code
([#1855](#1855))
([834a380](834a380))
* revert fallback on btree indexes when hash is unavailable
([#1858](#1858))
([1c7202f](1c7202f))
* update ip mismatch error message
([#1849](#1849))
([49fbbf0](49fbbf0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants