Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow setting the mailer service headers as strings #1861

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

kangmingtay
Copy link
Member

@kangmingtay kangmingtay commented Dec 6, 2024

What kind of change does this PR introduce?

  • Request made to email validation service should be a POST
  • Update error message when config validation fails

@kangmingtay kangmingtay requested a review from a team as a code owner December 6, 2024 08:25
@J0
Copy link
Contributor

J0 commented Dec 6, 2024

Let’s update the tests before merging

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12195997875

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 57.264%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/conf/configuration.go 0 1 0.0%
internal/mailer/validate.go 2 3 66.67%
Totals Coverage Status
Change from base Build 12192682911: -0.004%
Covered Lines: 9696
Relevant Lines: 16932

💛 - Coveralls

@kangmingtay kangmingtay changed the base branch from master to release/2.165.0 December 6, 2024 09:24
@kangmingtay kangmingtay merged commit 7907b56 into release/2.165.0 Dec 6, 2024
2 checks passed
@kangmingtay kangmingtay deleted the km/fix-mailer-config branch December 6, 2024 09:31
kangmingtay pushed a commit that referenced this pull request Dec 6, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.165.1](v2.165.0...v2.165.1)
(2024-12-06)


### Bug Fixes

* allow setting the mailer service headers as strings
([#1861](#1861))
([7907b56](7907b56))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants