fix: add createUser param to GenerateLink #1116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm slightly confused about this. Why was this closed? |
|
Hm yeah let me re-open this one. Thanks for flagging |
|
It's been a while so I can't recall but I think the initial hesitation was because I'll think about it + check in with team and get back. If you'd like to share more about potential use cases please feel free to do so |
|
Ah I think to preserve existing behaviour I'll likely revisit after attending to core priorities but for now will have to trouble you to make use of a trigger or other checks. Let me know if there are any suggestions though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What is the current behavior?
See: supabase/auth-js#358
What is the new behavior?
Introduces an additional parameter to GenerateLink which allows user to generate a magic link. Further thought is needed, leaving as draft for now.