feat: use OIDC ID token for Azure #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
commented
Oct 12, 2023
hf
commented
Oct 12, 2023
hf
commented
Oct 12, 2023
kangmingtay
requested changes
Oct 12, 2023
hf
force-pushed
the
hf/azure-id-token
branch
2 times, most recently
from
5d4df88 to
608284c
Compare
kangmingtay
approved these changes
Oct 13, 2023
hf
force-pushed
the
hf/azure-id-token
branch
4 times, most recently
from
582d93b to
c28cbca
Compare
kangmingtay
requested changes
Oct 15, 2023
kangmingtay
approved these changes
Oct 15, 2023
hf
commented
Oct 15, 2023
hf
force-pushed
the
hf/azure-id-token
branch
13 times, most recently
from
fdeeb99 to
74b58c6
Compare
hf
force-pushed
the
hf/azure-id-token
branch
2 times, most recently
from
fed3540 to
e9b120d
Compare
J0
reviewed
Oct 16, 2023
J0
approved these changes
Oct 16, 2023
hf
force-pushed
the
hf/azure-id-token
branch
8 times, most recently
from
b13f7d5 to
c337005
Compare
J0
reviewed
Oct 16, 2023
J0
reviewed
Oct 16, 2023
J0
approved these changes
Oct 16, 2023
Co-authored-by: Joel Lee <lee.yi.jie.joel@gmail.com>
|
🎉 This PR is included in version 2.102.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
hoeseong19
pushed a commit
to hoeseong19/gotrue
that referenced
this pull request
Oct 16, 2023
Use the OIDC ID token instead of the UserInfo endpoint, as there are serious discrepancies between what is returned. --------- Co-authored-by: Joel Lee <lee.yi.jie.joel@gmail.com>
|
@hf -- I've started getting the following error for Azure users logging in: Is this related to this PR? The errors began at the following timestamp: 2023-10-17T08:59:15.000Z. I am using multitenant sign in. Is the fix here? #1272. |
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
Use the OIDC ID token instead of the UserInfo endpoint, as there are serious discrepancies between what is returned. --------- Co-authored-by: Joel Lee <lee.yi.jie.joel@gmail.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
Use the OIDC ID token instead of the UserInfo endpoint, as there are serious discrepancies between what is returned. --------- Co-authored-by: Joel Lee <lee.yi.jie.joel@gmail.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
Use the OIDC ID token instead of the UserInfo endpoint, as there are serious discrepancies between what is returned. --------- Co-authored-by: Joel Lee <lee.yi.jie.joel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the OIDC ID token instead of the UserInfo endpoint, as there are serious discrepancies between what is returned.