From 4ebf71b8fa48b4dcd084878de88a8fe087fd46d4 Mon Sep 17 00:00:00 2001 From: joel Date: Mon, 12 Feb 2024 12:52:39 +0800 Subject: [PATCH 1/3] feat: deprecate webhooks --- README.md | 2 ++ internal/api/api.go | 3 +++ 2 files changed, 5 insertions(+) diff --git a/README.md b/README.md index 449fa3ca1..3070640f3 100644 --- a/README.md +++ b/README.md @@ -664,6 +664,8 @@ Default Content (if template is unavailable):

Change Email

``` +> ⚠️ As of 12th Feb 2024, Webhooks are deprecated and will be removed in the next release. We will be replacing the existing Webhooks implementation with a similar HTTP Hook system in the coming weeks. + `WEBHOOK_URL` - `string` Url of the webhook receiver endpoint. This will be called when events like `validate`, `signup` or `login` occur. diff --git a/internal/api/api.go b/internal/api/api.go index e592a23d9..1ef10cd9a 100644 --- a/internal/api/api.go +++ b/internal/api/api.go @@ -66,6 +66,9 @@ func (a *API) deprecationNotices(ctx context.Context) { if config.JWT.DefaultGroupName != "" { log.Warn("DEPRECATION NOTICE: GOTRUE_JWT_DEFAULT_GROUP_NAME not supported by Supabase's GoTrue, will be removed soon") } + if config.Webhook.URL != "" { + log.Warn("DEPRECATION NOTICE: GOTRUE_WEBHOOK_URL not supported by Supabase's GoTrue, all GOTRUE_WEBHOOK related configuration will be removed soon") + } } // NewAPIWithVersion creates a new REST API using the specified version From 95590f6eb427bca4ca55f17b97f8a2419270dfb2 Mon Sep 17 00:00:00 2001 From: Joel Lee Date: Mon, 12 Feb 2024 12:54:46 +0800 Subject: [PATCH 2/3] Update api.go --- internal/api/api.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/api/api.go b/internal/api/api.go index 1ef10cd9a..a973f0adf 100644 --- a/internal/api/api.go +++ b/internal/api/api.go @@ -67,7 +67,7 @@ func (a *API) deprecationNotices(ctx context.Context) { log.Warn("DEPRECATION NOTICE: GOTRUE_JWT_DEFAULT_GROUP_NAME not supported by Supabase's GoTrue, will be removed soon") } if config.Webhook.URL != "" { - log.Warn("DEPRECATION NOTICE: GOTRUE_WEBHOOK_URL not supported by Supabase's GoTrue, all GOTRUE_WEBHOOK related configuration will be removed soon") + log.Warn("DEPRECATION NOTICE: GOTRUE_WEBHOOK_URL not supported by Supabase's GoTrue, all GOTRUE_WEBHOOK related configuration will be removed after v2.139.2") } } From ce96edb67486d9736c81737016487a7cf20e0171 Mon Sep 17 00:00:00 2001 From: joel Date: Mon, 12 Feb 2024 12:59:38 +0800 Subject: [PATCH 3/3] feat: empty commit to see if it fixes build