fix: fallback on btree indexes when hash is unavailable #1856
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olirice
force-pushed
the
or/fallback-on-btree-when-hash-unavailable
branch
from
f047ba4 to
e98b9d3
Compare
Pull Request Test Coverage Report for Build 12162834089Details
💛 - Coveralls |
pashkinelfe
approved these changes
Dec 4, 2024
J0
approved these changes
Dec 4, 2024
J0
changed the title
J0
added a commit
that referenced
this pull request
Dec 4, 2024
Reverts #1856. We plan to roll this out in the next version (v2.166.0) as per internal discussion
cstockton
pushed a commit
that referenced
this pull request
Dec 5, 2024
🤖 I have created a release *beep* *boop* --- ## [2.165.0](v2.164.0...v2.165.0) (2024-12-05) ### Features * add email validation function to lower bounce rates ([#1845](#1845)) ([2c291f0](2c291f0)) * use embedded migrations for `migrate` command ([#1843](#1843)) ([e358da5](e358da5)) ### Bug Fixes * fallback on btree indexes when hash is unavailable ([#1856](#1856)) ([b33bc31](b33bc31)) * return the error code instead of status code ([#1855](#1855)) ([834a380](834a380)) * revert fallback on btree indexes when hash is unavailable ([#1858](#1858)) ([1c7202f](1c7202f)) * update ip mismatch error message ([#1849](#1849)) ([49fbbf0](49fbbf0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Edits an existing migration to fallback onto btree indexes when hash indexes are unavailable.
This change allows auth to be compatible with the orioledb storage engine. At time of writing orioledb only support btree indexes. That issue is expected to be addressed by the end of Q1 - 2025. Once that support is added, both heap and orioledb projects will both use the code path for hash indexes. hash indexes are preferred because they are safer from timing attacks
A reminder has been set for May 1st for us to