From 19a1c82aea3a6e5acf4d5bf2d8f0998550034c10 Mon Sep 17 00:00:00 2001 From: Cemal Kilic Date: Wed, 18 Jun 2025 00:29:15 +0200 Subject: [PATCH] fix: add missing provider info to signedup audit logs --- internal/api/admin.go | 1 + internal/api/provider_constants.go | 7 +++++++ internal/api/verify.go | 12 +++++++++--- 3 files changed, 17 insertions(+), 3 deletions(-) create mode 100644 internal/api/provider_constants.go diff --git a/internal/api/admin.go b/internal/api/admin.go index f8188d578..2217ccb54 100644 --- a/internal/api/admin.go +++ b/internal/api/admin.go @@ -461,6 +461,7 @@ func (a *API) adminUserCreate(w http.ResponseWriter, r *http.Request) error { "user_id": user.ID, "user_email": user.Email, "user_phone": user.Phone, + "provider": providers[0], // complying with the user.AppMetaData["provider"] field as above }); terr != nil { return terr } diff --git a/internal/api/provider_constants.go b/internal/api/provider_constants.go new file mode 100644 index 000000000..4c246cb88 --- /dev/null +++ b/internal/api/provider_constants.go @@ -0,0 +1,7 @@ +package api + +// Provider constants +const ( + EmailProvider = "email" + PhoneProvider = "phone" +) diff --git a/internal/api/verify.go b/internal/api/verify.go index f86e6802e..6a98c9e4b 100644 --- a/internal/api/verify.go +++ b/internal/api/verify.go @@ -322,7 +322,9 @@ func (a *API) signupVerify(r *http.Request, ctx context.Context, conn *storage.C } } - if terr = models.NewAuditLogEntry(r, tx, user, models.UserSignedUpAction, "", nil); terr != nil { + if terr = models.NewAuditLogEntry(r, tx, user, models.UserSignedUpAction, "", map[string]interface{}{ + "provider": EmailProvider, + }); terr != nil { return terr } @@ -357,7 +359,9 @@ func (a *API) recoverVerify(r *http.Request, conn *storage.Connection, user *mod return terr } if !user.IsConfirmed() { - if terr = models.NewAuditLogEntry(r, tx, user, models.UserSignedUpAction, "", nil); terr != nil { + if terr = models.NewAuditLogEntry(r, tx, user, models.UserSignedUpAction, "", map[string]interface{}{ + "provider": EmailProvider, + }); terr != nil { return terr } @@ -383,7 +387,9 @@ func (a *API) smsVerify(r *http.Request, conn *storage.Connection, user *models. err := conn.Transaction(func(tx *storage.Connection) error { if params.Type == smsVerification { - if terr := models.NewAuditLogEntry(r, tx, user, models.UserSignedUpAction, "", nil); terr != nil { + if terr := models.NewAuditLogEntry(r, tx, user, models.UserSignedUpAction, "", map[string]interface{}{ + "provider": PhoneProvider, + }); terr != nil { return terr } if terr := user.ConfirmPhone(tx); terr != nil {