docs: remove net._http_collect_response usage #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _http_collect_response was never meant to be used by end users. It only was meant as an internal function for testing. Why? Because it uses an endless loop (net._await_response) which is not safe when running inside a transaction. Previously it was removed from https://supabase.com/docs/guides/database/extensions/pg_net For the same reason. If there's a need for sync requests, the current recommendation is to use pgsql-http.
olirice
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
net._http_collect_responsewas never meant to be used by end users. It only was meant as an internal function for testing.Why? Because it uses an endless loop (
net._await_response) which is not safe when running inside a transaction.Previously it was removed from
https://supabase.com/docs/guides/database/extensions/pg_net
For the same reason.
If there's a need for sync requests, the current recommendation is to use pgsql-http.
cc @TheOtherBrian1