Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: queries respect migrations columns #531

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Aug 9, 2024

What kind of change does this PR introduce?

Improvement

What is the new behavior?

This PR allows us to keep backwards compatible queries depending on the latest migration run.
It will be a smoother way to transition between versions of Storage

Copy link

github-actions bot commented Aug 9, 2024

Pull Request Test Coverage Report for Build 10316324330

Details

  • 89 of 112 (79.46%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 79.423%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/routes/admin/tenants.ts 0 2 0.0%
src/http/plugins/db.ts 9 13 69.23%
src/storage/database/knex.ts 44 61 72.13%
Totals Coverage Status
Change from base Build 10301007939: -0.03%
Covered Lines: 13311
Relevant Lines: 16600

💛 - Coveralls

@fenos fenos force-pushed the migrations/allow-excluding-columns-for-old-migrations branch from 1323c56 to da54fc5 Compare August 9, 2024 14:39
@fenos fenos merged commit 029d0f5 into master Aug 10, 2024
1 check passed
@fenos fenos deleted the migrations/allow-excluding-columns-for-old-migrations branch August 10, 2024 09:46
Copy link

🎉 This PR is included in version 1.9.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants