Refactor structure & categories field #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import {superdeskApi} from '../../../superdeskApi'; | ||
| import {IFieldGetter} from '.'; | ||
|
|
||
| export const getPlaceField: IFieldGetter = () => ({ |
There was a problem hiding this comment.
IFieldGetter doesn't server any purpose here compared to
const getPlaceField = (): IFieldDefinition => {...}
| }, | ||
| }, | ||
| { | ||
| fieldId: 'agendas', |
There was a problem hiding this comment.
Should this be present in the refactored code too?
There was a problem hiding this comment.
Yes, I've deleted it on accident
tomaskikutis
approved these changes
Dec 13, 2024
thecalcc
merged commit d0803e2
into
superdesk:authoring-react-planning
10 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STT-63
Front-end checklist
memoorPureComponentto define new React components (and updates existing usages in modified code segments)lodash.getwith optional chaining and nullish coalescing for modified code segmentssuperdeskApi)superdesk-ui-frameworkandsuperdeskApiwhen possible instead of using ones defined in this repository.planningApiwhere it is possible to usesuperdeskApiplanningApi)