Generic batching #34
Merged
Generic batching #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superdump
approved these changes
Sep 17, 2023
| type CompareData: PartialEq; | ||
| type BufferData: GpuArrayBufferable + Sync + Send + 'static; | ||
| fn get_batch_data( | ||
| batch_data: <Self::Query as WorldQuery>::Item<'_>, |
There was a problem hiding this comment.
Hmm, what should this anonymous lifetime be? Seems a bit sus in an API?
There was a problem hiding this comment.
I guess it doesn't matter as it's only borrowed for the duration of get_batch_data, for now?
Comment on lines
+127
to
+135
| pub fn flush_buffer<F: GetBatchData>( | ||
| render_device: Res<RenderDevice>, | ||
| render_queue: Res<RenderQueue>, | ||
| gpu_array_buffer: ResMut<GpuArrayBuffer<F::BufferData>>, | ||
| ) { | ||
| let gpu_array_buffer = gpu_array_buffer.into_inner(); | ||
| gpu_array_buffer.write_buffer(&render_device, &render_queue); | ||
| gpu_array_buffer.clear(); | ||
| } |
There was a problem hiding this comment.
Good! I wanted to separate this out so we could allow others to append stuff to the buffer for their own purposes.
| @@ -97,7 +94,9 @@ impl Plugin for Mesh2dRenderPlugin { | |||
| .add_systems( | |||
| Render, | |||
| ( | |||
| prepare_and_batch_meshes2d.in_set(RenderSet::PrepareResources), | |||
| batch_render_phase::<Transparent2d, Mesh2dPipeline> | |||
| .in_set(RenderSet::PrepareResources), | |||
There was a problem hiding this comment.
Nice that this just becomes a system.
| type BufferData = Mesh2dUniform; | ||
|
|
||
| fn get_batch_data( | ||
| (material_bind_group_id, mesh_handle, mesh_transforms): <Self::Query as bevy_ecs::query::WorldQuery>::Item<'_>, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.