Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE-RELEASE-0.4] [BUG] During encoding, leaf uses the identifier as the key for _builds, causing conflicts. #2451

Closed
Tracked by #2413
jieguangzhou opened this issue Sep 12, 2024 · 0 comments · Fixed by #2464
Assignees
Labels
🐛 bug Something isn't working

Comments

@jieguangzhou
Copy link
Collaborator

jieguangzhou commented Sep 12, 2024

When the data contains different type_ids but the same identifier, it will result in errors.

from superduper import ObjectModel, Listener, Application, Document
model = ObjectModel(identifier="model1", object= lambda x: x)
listener = model.to_listener(identifier="model1", key="a", select=None)
application = Application(identifier="app", components=[listener])
encode_data = application.encode()
Document.decode(encode_data)

It's recommended to use "{type_id}:{identifier}" as the key in _builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant