remove unUse import

[EdwardLi-coder]

Description

remove unUse import function

Related Issues

Cannot Find Reference to _build_leaves Function(fix #2294 )

Checklist

• Is this code covered by new or existing unit tests or integration tests?
• Did you run make unit_testing and make integration-testing successfully?
• Do new classes, functions, methods and parameters all have docstrings?
• Were existing docstrings updated, if necessary?
• Was external documentation updated, if necessary?

Additional Notes or Comments

[jieguangzhou]

@EdwardLi-coder Could you update the CHANGELOG?

[EdwardLi-coder]

@EdwardLi-coder Could you update the CHANGELOG?

I’m sorry, but I’m not sure where exactly to update the CHANGELOG. Could you please provide me with more details? Thank you.

[jieguangzhou]

@EdwardLi-coder Could you update the CHANGELOG?

I’m sorry, but I’m not sure where exactly to update the CHANGELOG. Could you please provide me with more details? Thank you.

https://github.com/superduper-io/superduper/blob/main/CHANGELOG.md this file.

Under the 0.3.0 -> Bug Fixes

[EdwardLi-coder]

@EdwardLi-coder Could you update the CHANGELOG?

I’m sorry, but I’m not sure where exactly to update the CHANGELOG. Could you please provide me with more details? Thank you.

https://github.com/superduper-io/superduper/blob/main/CHANGELOG.md this file.

Under the 0.3.0 -> Bug Fixes

Ok.

[jieguangzhou]

Hey @EdwardLi-coder , the CI didn't pass, you need to make sure the lint check is OK

Please remove the unused import thing, and run make lint-and-type-check, if it passes, I think the CI will pass

superduper/components/component.py:17:49: F401 [*] `superduper.base.constant.KEY_BUILDS` imported but unused

Run make lint-and-type-check
===> Code Formatting <===
black --check superduper test
All done! ✨ 🍰 ✨
222 files would be left unchanged.
ruff check superduper test
warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'extend-select' -> 'lint.extend-select'
  - 'ignore' -> 'lint.ignore'
  - 'isort' -> 'lint.isort'
  - 'per-file-ignores' -> 'lint.per-file-ignores'
warning: `one-blank-line-before-class` (D203) and `no-blank-line-before-class` (D211) are incompatible. Ignoring `one-blank-line-before-class`.
warning: Docstring at superduper/backends/base/artifacts.py:92:9 contains implicit string concatenation; ignoring...
superduper/components/component.py:17:49: F401 [*] `superduper.base.constant.KEY_BUILDS` imported but unused
Found 1 error.
[*] 1 fixable with the `--fix` option.
make: *** [Makefile:74: lint-and-type-check] Error 1

[EdwardLi-coder]

Hey @EdwardLi-coder , the CI didn't pass, you need to make sure the lint check is OK

Please remove the unused import thing, and run make lint-and-type-check, if it passes, I think the CI will pass

superduper/components/component.py:17:49: F401 [*] `superduper.base.constant.KEY_BUILDS` imported but unused

Run make lint-and-type-check
===> Code Formatting <===
black --check superduper test
All done! ✨ 🍰 ✨
222 files would be left unchanged.
ruff check superduper test
warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'extend-select' -> 'lint.extend-select'
  - 'ignore' -> 'lint.ignore'
  - 'isort' -> 'lint.isort'
  - 'per-file-ignores' -> 'lint.per-file-ignores'
warning: `one-blank-line-before-class` (D203) and `no-blank-line-before-class` (D211) are incompatible. Ignoring `one-blank-line-before-class`.
warning: Docstring at superduper/backends/base/artifacts.py:92:9 contains implicit string concatenation; ignoring...
superduper/components/component.py:17:49: F401 [*] `superduper.base.constant.KEY_BUILDS` imported but unused
Found 1 error.
[*] 1 fixable with the `--fix` option.
make: *** [Makefile:74: lint-and-type-check] Error 1

ok

[EdwardLi-coder]

Hi @jieguangzhou. I successfully ran the make lint-and-type-check command locally, but it failed in the CI. I am using the latest versions of both black and ruff.Do you have any suggestions? Should I consider using an older version?

[jieguangzhou]

@EdwardLi-coder , you can run make install_devkit to install the version we used and please rebase the main branch, thanks

install_devkit: ## Add essential development tools
	# Add pre-commit hooks to ensure that no strange stuff are being committed.
	# https://stackoverflow.com/questions/3462955/putting-git-hooks-into-a-repository
	python -m pip install pre-commit

	@echo "Download Code Quality dependencies"
	python -m pip install --user black==23.3 ruff==0.4.4 mypy types-PyYAML types-requests interrogate

	@echo "Download Code Testing dependencies"
	python -m pip install --user pytest pytest-cov "nbval>=0.10.0"

[EdwardLi-coder]

@EdwardLi-coder , you can run make install_devkit to install the version we used and please rebase the main branch, thanks

install_devkit: ## Add essential development tools
	# Add pre-commit hooks to ensure that no strange stuff are being committed.
	# https://stackoverflow.com/questions/3462955/putting-git-hooks-into-a-repository
	python -m pip install pre-commit

	@echo "Download Code Quality dependencies"
	python -m pip install --user black==23.3 ruff==0.4.4 mypy types-PyYAML types-requests interrogate

	@echo "Download Code Testing dependencies"
	python -m pip install --user pytest pytest-cov "nbval>=0.10.0"

I updated it. One succeeded, and one failed. I found the reason for the failure: it was a read timeout. Is there anything else you need me to do?

[jieguangzhou]

@EdwardLi-coder Hey, thanks for your PR, I merged

[EdwardLi-coder]

@EdwardLi-coder Hey, thanks for your PR, I merged

OK.