Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version (v)ery confussing #62

Open
2 tasks
mountainash opened this issue Jul 5, 2024 · 0 comments
Open
2 tasks

Version (v)ery confussing #62

mountainash opened this issue Jul 5, 2024 · 0 comments

Comments

@mountainash
Copy link

Semi-related to #59

Setting the version "with" argument to the latest release causes the Action to fail/throw without an error 😿 (even when setting GHActions to run in "debug" mode).

Screenshot of this Action failing on GitHub Actions UI in Debug mode

I've tried the following variations of pinning the version:

  with:
    version: 0.2.80
OR
    version: v0.2.80
OR
    version: 'v0.2.80'

Without setting the version the Action installs the FLY CLI as expected, but it's installing an older version from https://github.com/superfly/flyctl/releases/download/v0.2.72/flyctl_0.2.72_Linux_x86_64.tar.gz

  • could the version arg be checked for a v prefix and add/remove it if it's needed
  • could a descriptive error be thrown when the binary can't be found

Extra: my preference would be to allow the version number to be pinned in D.D.DD format (without the v prefix to be inline with other popular Actions.

Screenshot of a Workflow YAML showing Digital Ocean Action and Bun Action with pinned version numbers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant