Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor graphchain #33

Merged
merged 51 commits into from
Oct 20, 2018
Merged

Refactor graphchain #33

merged 51 commits into from
Oct 20, 2018

Conversation

lsorber
Copy link
Member

@lsorber lsorber commented Jul 31, 2018

Resolves #16, #19, #30, #31, #32.

Additional features in this PR:

  • If two keys map to the same computation, fetching both these keys will result in only one of them actually being computed while the other is loaded from cache (cf. example_5.py).
  • The previous point also applies recursively, i.e., two computations are "the same" even if they depend on different keys, as long as those keys result in the same output (cf. example_5.py).
  • Caching is no longer done by default, but only if it saves time. The definition of saving time depends on the time it would take to compute the key and load the necessary dependencies vs. the time to load the key from cache.
  • Adds a log trail to the cache folder. Can later be used to do housekeeping.

@lsorber lsorber self-assigned this Jul 31, 2018
@lsorber lsorber requested a review from zgornel July 31, 2018 19:04
@lsorber lsorber changed the title Refactor graphchain WIP Refactor graphchain Jul 31, 2018
@lsorber lsorber changed the title WIP Refactor graphchain Refactor graphchain Jul 31, 2018
@lsorber lsorber changed the title Refactor graphchain WIP Refactor graphchain Jul 31, 2018
@lsorber lsorber changed the title WIP Refactor graphchain Refactor graphchain Aug 6, 2018
Copy link
Contributor

@zgornel zgornel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; did not have enough to test it extensively however so far so good :). It may be time to merge and leave the old implementation on a legacy branch or something for reference (if it makes sense).

@lsorber lsorber merged commit e2c21af into master Oct 20, 2018
@lsorber lsorber deleted the ls-refactor branch October 20, 2018 10:24
This was referenced Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants