-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Slider API, Juce patches, and sldierClicked/triggerClick #12
Comments
Looking at this code, if I was going to fix this with juce 6 I would
basically. The mouseEvent stuff that subclass could do with an override and pass to parent trick too I think that's the approach from the diff. Not working on it now, just read the diff and wanted to toss that here |
After a little research, it seems there is no need to reimplement the patched slider API. The main purpose for the patch was an advanced and complex slider context menu with the features listed below. The global features could be moved to a global dialogue. Any suggestion for the individual ones? Global: Value:
Slider behaviour:
Animations:
Help:
Persistence:
Engine:
Individual slider settings: Value:
MIDI:
|
So on the individual ones, we should still be able to pop them up on the slider menu, just we need to intercept it at a different point, no? (Although I haven't been that deeply in the code structure to understand why). The problem is you aren't getting the chance at the mouseDown event basically so you can't just popup a menu with showMenuAsync? |
There was and is still no way to customize the slider popupMenu. There is just one method to enable it as it is (void setPopupMenuEnabled (bool menuEnabled)) |
Right So I have little project called 'toy-juce' i use to experiment with the juce api. right now it is a plugin with a bunch of params that shows sliders about those params. I just modified the slider class I use to have a custom popup menu. Critically it doesn't use setPopupMenuEnabled but instead overrides mouseDown on the class there's the class So when I run that the slider works normally unless I dod a popup menu gesture, in which case it shows me my menu rather than the default one. Does that help at all? Perhaps introduce a monique_BaseSlider which is subclass of juce::Slider with that override in place and use that everywhere else in monique as your slider base class? |
Thanks, Paul! Yes, this helps. Easy and simple solution – great! |
Monique had modified JUCE to add a couple of methods to slider, including 'sliderClicked' and 'triggerClick'. In the port to juce 6 unpatched, I commented these out for now while we figure out the right juce 6 strategy.
Where I did I used
before the commented out code so we can find a lot of them and will see them in the debugger at runtime.
The text was updated successfully, but these errors were encountered: