From 8c8e0e320790868b5f137c01f7242a73c2a3d91d Mon Sep 17 00:00:00 2001 From: baseballyama Date: Sun, 12 Jan 2025 22:14:04 +0900 Subject: [PATCH 1/3] =?UTF-8?q?chore:=20run=20the=20`no-inspect`=20rule=20?= =?UTF-8?q?only=20in=20Svelte=205=E2=80=99s=20runes=20mode?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .changeset/smart-apes-confess.md | 5 +++++ packages/eslint-plugin-svelte/src/rules/no-inspect.ts | 8 +++++++- 2 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 .changeset/smart-apes-confess.md diff --git a/.changeset/smart-apes-confess.md b/.changeset/smart-apes-confess.md new file mode 100644 index 000000000..922c2c9e8 --- /dev/null +++ b/.changeset/smart-apes-confess.md @@ -0,0 +1,5 @@ +--- +'eslint-plugin-svelte': patch +--- + +chore: run the `no-inspect` rule only in Svelte 5’s runes mode diff --git a/packages/eslint-plugin-svelte/src/rules/no-inspect.ts b/packages/eslint-plugin-svelte/src/rules/no-inspect.ts index 1a46a3232..b085d2ada 100644 --- a/packages/eslint-plugin-svelte/src/rules/no-inspect.ts +++ b/packages/eslint-plugin-svelte/src/rules/no-inspect.ts @@ -15,7 +15,13 @@ export default createRule('no-inspect', { messages: { unexpected: 'Do not use $inspect directive' }, - type: 'suggestion' + type: 'suggestion', + conditions: [ + { + svelteVersions: ['5'], + runes: [true, 'undetermined'] + } + ] }, create(context) { return { From 71412f9313b67cdb92aead45c57ff337b9f22211 Mon Sep 17 00:00:00 2001 From: baseballyama Date: Sun, 12 Jan 2025 22:19:03 +0900 Subject: [PATCH 2/3] requirements --- .../tests/fixtures/rules/no-inspect/invalid/requirements.json | 3 +++ .../tests/fixtures/rules/no-inspect/valid/requirements.json | 3 +++ 2 files changed, 6 insertions(+) create mode 100644 packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/invalid/requirements.json create mode 100644 packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/valid/requirements.json diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/invalid/requirements.json b/packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/invalid/requirements.json new file mode 100644 index 000000000..0192b1098 --- /dev/null +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/invalid/requirements.json @@ -0,0 +1,3 @@ +{ + "svelte": ">=5.0.0-0" +} diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/valid/requirements.json b/packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/valid/requirements.json new file mode 100644 index 000000000..0192b1098 --- /dev/null +++ b/packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/valid/requirements.json @@ -0,0 +1,3 @@ +{ + "svelte": ">=5.0.0-0" +} From 9d2d15a1773de6210b32d0546f4663d66c8773d0 Mon Sep 17 00:00:00 2001 From: Yosuke Ota Date: Tue, 14 Jan 2025 06:00:00 +0000 Subject: [PATCH 3/3] rename _requirements.json --- .../no-inspect/invalid/{requirements.json => _requirements.json} | 0 .../no-inspect/valid/{requirements.json => _requirements.json} | 0 2 files changed, 0 insertions(+), 0 deletions(-) rename packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/invalid/{requirements.json => _requirements.json} (100%) rename packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/valid/{requirements.json => _requirements.json} (100%) diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/invalid/requirements.json b/packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/invalid/_requirements.json similarity index 100% rename from packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/invalid/requirements.json rename to packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/invalid/_requirements.json diff --git a/packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/valid/requirements.json b/packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/valid/_requirements.json similarity index 100% rename from packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/valid/requirements.json rename to packages/eslint-plugin-svelte/tests/fixtures/rules/no-inspect/valid/_requirements.json