-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove build step for adapter node #10041
Conversation
🦋 Changeset detectedLatest commit: 1a6ce3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
It doesn't work on windows, what a surprise. But only the sverdle page, whyyyyyyyyyy Nvm, I'm dum and the server on WSL wasn't killed properly |
#10040 could be solved by either reading the files directly from outDir/output/server Are there any downsides to that? Alternatively copying them to a folder adjacent to outDir/output/server so that the relative paths stay in the correct location. But both of those require the adpater to know that the files are in outDir/output/server |
Ah, I see you've removed I think this is an exciting change. When we were running into the memory leak issue in undici, I remember there was confusion arising from how only bumping the version in Kit wasn't enough to get the fix out to people, because adapter-node was bundling it. That's reason enough alone to stop bundling this, I think. I see that adapter-cloudflare and adapter-netlify also have build steps. I'm not entirely sure that adapter-cloudflare's is doing, but it looks like adapter-netlify's build step is also bundling |
Also updated it to copy files to an adjacent directory, relative paths in sourcemaps should resolve correctly that way. Which should perhaps fix #10040 , @danieldiekmeier can you link to this PR and check? |
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
Any chance this could get fixed and remerged? It got reverted and still having problems with source maps not working. |
Adding to the noise here since I haven't seen any movement! Source maps are still wonky for sveltekit with adapter-node + sentry and it's making them very hard to use. |
todos:
maybe this addresses #10040, not surePlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.