From a07d8558f1d53846f52a675b027c81a7d9233e90 Mon Sep 17 00:00:00 2001 From: Chew Tee Ming Date: Wed, 11 Dec 2024 14:46:05 +0800 Subject: [PATCH 1/5] follow vite config setting --- packages/kit/src/exports/vite/build/build_service_worker.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/kit/src/exports/vite/build/build_service_worker.js b/packages/kit/src/exports/vite/build/build_service_worker.js index a7c11188d02a..3b7c1cfe38f9 100644 --- a/packages/kit/src/exports/vite/build/build_service_worker.js +++ b/packages/kit/src/exports/vite/build/build_service_worker.js @@ -105,7 +105,8 @@ export async function build_service_worker( } }, outDir: `${out}/client`, - emptyOutDir: false + emptyOutDir: false, + minify: vite_config.build.minify }, configFile: false, define: vite_config.define, From 734b5bf680657291bd7f7423530c48b69e36bd7d Mon Sep 17 00:00:00 2001 From: Chew Tee Ming Date: Wed, 11 Dec 2024 15:07:46 +0800 Subject: [PATCH 2/5] pass initial config to service worker build --- packages/kit/src/exports/vite/index.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/kit/src/exports/vite/index.js b/packages/kit/src/exports/vite/index.js index e6521e979560..e141d0d2d207 100644 --- a/packages/kit/src/exports/vite/index.js +++ b/packages/kit/src/exports/vite/index.js @@ -886,7 +886,13 @@ async function kit({ svelte_config }) { await build_service_worker( out, kit, - vite_config, + { + ...vite_config, + build: { + ...vite_config.build, + minify: initial_config.build?.minify ?? 'esbuild', + } + }, manifest_data, service_worker_entry_file, prerendered, From be54de9bd4e920410004e0e353e43d7ebacce3f8 Mon Sep 17 00:00:00 2001 From: Chew Tee Ming Date: Wed, 11 Dec 2024 15:08:42 +0800 Subject: [PATCH 3/5] changeset --- .changeset/rotten-cheetahs-complain.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/rotten-cheetahs-complain.md diff --git a/.changeset/rotten-cheetahs-complain.md b/.changeset/rotten-cheetahs-complain.md new file mode 100644 index 000000000000..d9076f6ff34e --- /dev/null +++ b/.changeset/rotten-cheetahs-complain.md @@ -0,0 +1,5 @@ +--- +'@sveltejs/kit': patch +--- + +fix: adhere to Vite config minify setting when building service worker From 2ab1e43c46705a2f29826dc420703779b5385469 Mon Sep 17 00:00:00 2001 From: Tee Ming Date: Wed, 11 Dec 2024 15:11:28 +0800 Subject: [PATCH 4/5] Update .changeset/rotten-cheetahs-complain.md --- .changeset/rotten-cheetahs-complain.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/rotten-cheetahs-complain.md b/.changeset/rotten-cheetahs-complain.md index d9076f6ff34e..1650a70be1a4 100644 --- a/.changeset/rotten-cheetahs-complain.md +++ b/.changeset/rotten-cheetahs-complain.md @@ -2,4 +2,4 @@ '@sveltejs/kit': patch --- -fix: adhere to Vite config minify setting when building service worker +fix: adhere to Vite `build.minify` setting when building the service worker From e777827b1a1cad643dd6df3e21dfb996df6cb99d Mon Sep 17 00:00:00 2001 From: Chew Tee Ming Date: Wed, 11 Dec 2024 15:25:21 +0800 Subject: [PATCH 5/5] format --- packages/kit/src/exports/vite/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/kit/src/exports/vite/index.js b/packages/kit/src/exports/vite/index.js index e141d0d2d207..2c76a71f0026 100644 --- a/packages/kit/src/exports/vite/index.js +++ b/packages/kit/src/exports/vite/index.js @@ -890,7 +890,7 @@ async function kit({ svelte_config }) { ...vite_config, build: { ...vite_config.build, - minify: initial_config.build?.minify ?? 'esbuild', + minify: initial_config.build?.minify ?? 'esbuild' } }, manifest_data,