dev/preview paths

[Rich-Harris]

following up #2145 (comment)

Before submitting the PR, please make sure you do the following

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

[changeset-bot]

🦋 Changeset detected

Latest commit: 311303c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Rich-Harris]

This is mostly done, but we're sort of blocked by vitejs/vite#2009 — because the asset path used by __vitePreload is hardcoded, it will preload JS and CSS from the wrong location.

[Rich-Harris]

Also, need to update the docs

[Rich-Harris]

One thing I missed somehow is that we're still not actually serving the app on the basepath during dev and preview. Working on that

[Rich-Harris]

Ok, this is basically done apart from docs, I think. I don't think vitejs/vite#2009 should block us, since it's not a regression — it just means that if you're using assets you will experience errors in svelte-kit preview.

[Rich-Harris]

will do docs after lunch

[benmccann]

I wonder if you could create a variable for parsed.pathname.startsWith(config.kit.paths.base) to avoid prettier indenting all the subsequent lines

[Rich-Harris]

it won't make any difference, it could be x && and prettier would still put them on separate lines

[benmccann]

Ah. You could change it like this to avoid the extra indentation:

				if (!parsed.pathname.startsWith(config.kit.paths.base)) {
					res.statusCode = 404;
					res.end('Not found');
					return;
				}
				const rendered = await respond(

[Rich-Harris]

we could, i just don't love the duplication of

res.statusCode = 404;
res.end('Not found');

maybe it's the lesser of two evils. not sure

[benmccann]

could refactor that out:

function not_found(res) {
  res.statusCode = 404;
  res.end('Not found');
}
if (!parsed.pathname.startsWith(config.kit.paths.base)) {
  return not_found(res);
}

[benmccann]

Nice! This looks like it cleans some stuff up a bit