From ee2c2540a36a2e5c08fb0b780879a2ad4be7e917 Mon Sep 17 00:00:00 2001 From: Harry Allen <66224939+MajesticString@users.noreply.github.com> Date: Wed, 11 May 2022 20:22:10 -0700 Subject: [PATCH 1/3] fix: fix: more relyable typings of config.kit.prerender.entries --- packages/kit/src/core/config/index.spec.js | 1 + packages/kit/types/index.d.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/kit/src/core/config/index.spec.js b/packages/kit/src/core/config/index.spec.js index eda31028f8b5..a7fb2b5e07c1 100644 --- a/packages/kit/src/core/config/index.spec.js +++ b/packages/kit/src/core/config/index.spec.js @@ -284,6 +284,7 @@ test('fails if prerender.entries are invalid', () => { validate_config({ kit: { prerender: { + // @ts-expect-error - given value expected to throw entries: ['foo'] } } diff --git a/packages/kit/types/index.d.ts b/packages/kit/types/index.d.ts index 3629cf0c66d2..ead4ff5f4d13 100644 --- a/packages/kit/types/index.d.ts +++ b/packages/kit/types/index.d.ts @@ -136,7 +136,7 @@ export interface Config { crawl?: boolean; default?: boolean; enabled?: boolean; - entries?: string[]; + entries?: Array<'*' | `/${string}`>; onError?: PrerenderOnErrorValue; }; routes?: (filepath: string) => boolean; From 14174a88aa7d4dcbd281a9d336ce6dbe8accda79 Mon Sep 17 00:00:00 2001 From: Harry Allen <66224939+MajesticString@users.noreply.github.com> Date: Wed, 11 May 2022 20:44:54 -0700 Subject: [PATCH 2/3] Create changeset file --- .changeset/long-turkeys-boil.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/long-turkeys-boil.md diff --git a/.changeset/long-turkeys-boil.md b/.changeset/long-turkeys-boil.md new file mode 100644 index 000000000000..b946da853ba8 --- /dev/null +++ b/.changeset/long-turkeys-boil.md @@ -0,0 +1,5 @@ +--- +"@sveltejs/kit": patch +--- + +fix: more reliable typings of config.kit.prerender.entries From 62b76f6a88cc854ed0bba9a6f82667a48050654e Mon Sep 17 00:00:00 2001 From: Harry Allen <66224939+MajesticString@users.noreply.github.com> Date: Wed, 11 May 2022 20:53:03 -0700 Subject: [PATCH 3/3] Update .changeset/long-turkeys-boil.md Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> --- .changeset/long-turkeys-boil.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/long-turkeys-boil.md b/.changeset/long-turkeys-boil.md index b946da853ba8..a332c2e2b7a6 100644 --- a/.changeset/long-turkeys-boil.md +++ b/.changeset/long-turkeys-boil.md @@ -2,4 +2,4 @@ "@sveltejs/kit": patch --- -fix: more reliable typings of config.kit.prerender.entries +[feat] more specific types for `kit.prerender.entries` config