-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Vite 3.2 #7400
Upgrade to Vite 3.2 #7400
Conversation
|
Does 3.2 provide any new features we're going to want to make use of? Before we hit SvelteKit 1.0 is the time to be doing any bumping of peerdeps. |
There's not much in 3.2 that affects us. Only thing I see in the changelog is vitejs/vite#9970, which is a bug fix for #1042 |
just triggered a rerun of tests on #7355 that should go in first otherwise it gets breaking changes from this here. ofc. we can also just redo it after, but would rather not |
We can't merge this anyway. |
someone mentioned adding types/picomatch to devDependencies as a workaround. We can either do that or wait until fixed in vite. Also checking if we can enable out lint in ecosystem-ci to catch these earlier. |
fix has already been merged in vite, so better to wait here and bump to 3.2.1 |
i bumped esbuild across the board so that we don't end up with two versions in the lockfile |
Sounds good |
I wasn't sure if I should include a changeset and didn't for now. This mostly affects tests.
create-svelte
does use a newer version, but you'd have already gotten the latest upon usingnpm install
previously, so I'm not sure there's really a user-visible change here