-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent unnecessary __data.json
requests
#8636
Conversation
🦋 Changeset detectedLatest commit: ead8fa8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👀 |
Why do we need to swap the order of the builds? One concern I have with that is that we've gotten requests not to do the server-side build for SPAs, etc. That becomes harder if the server-side build is the primary build |
You can't not do the server side build! Just because you're not rendering the body content doesn't mean you don't need a server. The server needs to go first because the client manifest needs to know which nodes have server loads. We can't know that without doing the server build (and analysing it) before the client build. |
If you're building a SPA with fallback page and no server side endpoints, what do you need the server for exactly? |
To generate the fallback page (while respecting things like |
The CI fail seems to be consistent. Failed two times on Mac, both times with an error hinting that |
This reverts commit 068cbe8.
Hmm. The most likely explanation for that would be that the cross-process communication failed for some reason and the promise never resolved, which makes me nervous |
b794a55
to
e900343
Compare
This will close #7967
Also fixes #8655
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.