-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition tests fail with latest jsdom #1127
Comments
The one final test failure looks to be fixed by updating to the just-releast jsdom 11.6.1 (in addition to making the above |
Note that recent versions of jsdom include a |
update jsdom; update `window.performance.now` test shim
closing. thank you! |
Couple of things going on here. When Rich cuts new builds, he (presumably) uses the dependencies as installed by Yarn, whereas CI uses npm and gets the latest versions of all dependencies. If the releases use Yarn, probably the CI jobs should too. There should probably also be an effort to update deps regularly, since they get bundled.
The other issue here is that, with the latest version of jsdom (upgrade from 11.5.1 to 11.6.0), tests related to transitions fail. I believe this is partially/largely because of the change "Added a
window.performance
implementation, including the basics of the High Resolution Time specification:performance.now()
,performance.timeOrigin
, andperformance.toJSON()
." Indeed, if the hack in the tests is changed fromwindow.performance = { now: () => raf.time };
towindow.performance.now = () => raf.time;
, all but one of the tests pass (under the latest jsdom), although I'm not sure what this means.The text was updated successfully, but these errors were encountered: