Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition tests fail with latest jsdom #1127

Closed
Conduitry opened this issue Jan 25, 2018 · 3 comments
Closed

Transition tests fail with latest jsdom #1127

Conduitry opened this issue Jan 25, 2018 · 3 comments

Comments

@Conduitry
Copy link
Member

Conduitry commented Jan 25, 2018

Couple of things going on here. When Rich cuts new builds, he (presumably) uses the dependencies as installed by Yarn, whereas CI uses npm and gets the latest versions of all dependencies. If the releases use Yarn, probably the CI jobs should too. There should probably also be an effort to update deps regularly, since they get bundled.

The other issue here is that, with the latest version of jsdom (upgrade from 11.5.1 to 11.6.0), tests related to transitions fail. I believe this is partially/largely because of the change "Added a window.performance implementation, including the basics of the High Resolution Time specification: performance.now(), performance.timeOrigin, and performance.toJSON()." Indeed, if the hack in the tests is changed from window.performance = { now: () => raf.time }; to window.performance.now = () => raf.time;, all but one of the tests pass (under the latest jsdom), although I'm not sure what this means.

@Conduitry
Copy link
Member Author

The one final test failure looks to be fixed by updating to the just-releast jsdom 11.6.1 (in addition to making the above window.performance.now change).

@Zirro
Copy link
Contributor

Zirro commented Jan 26, 2018

Note that recent versions of jsdom include a requestAnimationFrame()-implementation when you enable the pretendToBeVisual option. If you don't need to use it in a way that's different from browsers, you might not have to shim it or modify window.performance.now() any more.

Rich-Harris added a commit that referenced this issue Jan 26, 2018
update jsdom; update `window.performance.now` test shim
@Rich-Harris
Copy link
Member

closing. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants