Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle ssr for reactivity/window #14681

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Dec 11, 2024

Closes #14680

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: a424a56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14681

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14681-svelte.vercel.app/

this is an automated message

@paoloricciuti
Copy link
Member Author

@Rich-Harris out of curiosity: why is device pixel ratio the only one that doesn't use ReactiveValue?

@Rich-Harris
Copy link
Member

Because there's no event that you can listen to, we need to track it with a media query that changes from true to false to indicate that it changed. But once that happens, the media query is no longer useful and we need to create a new one. You can't do that with createSubscriber because you can't create a new subscriber inside an old one

@Rich-Harris Rich-Harris merged commit edfc0a9 into main Dec 11, 2024
11 checks passed
@Rich-Harris Rich-Harris deleted the fix-reactivity-window branch December 11, 2024 23:22
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
@paoloricciuti
Copy link
Member Author

Because there's no event that you can listen to, we need to track it with a media query that changes from true to false to indicate that it changed. But once that happens, the media query is no longer useful and we need to create a new one. You can't do that with createSubscriber because you can't create a new subscriber inside an old one

Uh I just noticed the interpolation in the media query...that's a pretty fucked up API lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

imports from svelte/reactivity/window breaks (SvelteKit) SSR
2 participants