FIX #2446: apply bindings and event handlers in order #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colincasey
commented
May 11, 2019
| const this_binding = this.bindings.find(b => b.node.name === 'this'); | ||
|
|
||
| function getOrder (item) { | ||
| if (item instanceof EventHandler) { |
There was a problem hiding this comment.
This logic involving type detection seems a clunky but I'm not used to TypeScript. Is there a better way to handle this?
* master: (87 commits) -> v3.4.3 always add raw property to text nodes flesh out in/out transition tutorial chapter (sveltejs#2792) code style fix test fix tests Fix CRUD example to allow changing input values. Fixes sveltejs#2714 treat requestAnimationFrame as a noop on the server site: actions tutorial: destroy is not required (sveltejs#2776) Allow binding of <details> open site: add /faq redirect to GitHub wiki FAQ fix case sensitive import name, improve tsconfig type declarations for bundled files convert everything to TypeScript check for unknown props when creating component cleanup, improve comments typecheck npm script workarond for estree-walker related typings conflict compile/render-dom and other remaining typings ... # Conflicts: # src/compile/render-dom/wrappers/Element/index.ts
* master: Fix overwrite of 'offset' value in reactive statement fix slide example typos update svelte-repl (fixes download button) update svelte-repl update svelte-repl version use better eliza package gitignore workers add compiler typings to list of published files improve typings for animate, easing, transition, motion and internal apis update bundler worker fix gitignore fix types for easing functions fix build order generate internal-exports file update gitignore update folder structure - sveltejs#2790 bundle locally
# Conflicts: # src/compiler/compile/render_dom/wrappers/Element/index.ts
Codecov Report
@@ Coverage Diff @@
## master #2737 +/- ##
=======================================
Coverage 50.25% 50.25%
=======================================
Files 1 1
Lines 197 197
=======================================
Hits 99 99
Misses 98 98Continue to review full report at Codecov.
|
ghost
mentioned this pull request
|
Closing in favor of #4148, which resolved some conflicts. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only addresses #2446 by applying the bindings and event handlers in the order they were declared in the attributes.