Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3061 #3062

Closed
wants to merge 1 commit into from
Closed

Fixes #3061 #3062

wants to merge 1 commit into from

Conversation

mindrones
Copy link
Member

No description provided.

@Conduitry
Copy link
Member

We're kind of inconsistent with how we're doing this in the various <svelte:xxx tags in the docs. I'm not sure what makes the most sense. There probably some other cases where we should be using a self-closing tag. In the places where we are using it, it looks like there's no space before the forward slash, so we should probably be consistent about that.

@mindrones
Copy link
Member Author

Ah right right, I shamelessy edited the file on github 🙈
I'll make a proper PR asap! :)

@pngwn
Copy link
Member

pngwn commented Jun 20, 2019

Since all tags have to be closed in svelte, should we just be using the closed version even for tags that accept children (since that is at least valid)?

@Conduitry
Copy link
Member

Yeah I think that makes sense, always show the self-closing version. I think keep the section headings as they are (no slash), but use the self-closing forms in the example usages below the section names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants