From 0dc9b11037a166bfde84633e3c7e2e4de744c7e3 Mon Sep 17 00:00:00 2001
From: Carlos Ivanchuk <buhodev@proton.me>
Date: Sun, 18 Sep 2022 22:57:38 -0400
Subject: [PATCH 1/5] [fix] omit a11y warning on <video> when
 aria-hidden="true" (#7874)

* omit a11y warning on <video> when aria-hidden="true" \
\
* add test
---
 src/compiler/compile/nodes/Element.ts                      | 5 ++++-
 test/validator/samples/a11y-media-has-caption/input.svelte | 2 ++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/compiler/compile/nodes/Element.ts b/src/compiler/compile/nodes/Element.ts
index 79f2800437bf..307d68dabd44 100644
--- a/src/compiler/compile/nodes/Element.ts
+++ b/src/compiler/compile/nodes/Element.ts
@@ -686,7 +686,10 @@ export default class Element extends Node {
 		}
 
 		if (this.name === 'video') {
-			if (attribute_map.has('muted')) {
+			const aria_hidden_attribute = attribute_map.get('aria-hidden');
+			const aria_hidden_exist = aria_hidden_attribute && aria_hidden_attribute.get_static_value();
+
+			if (attribute_map.has('muted') || aria_hidden_exist) {
 				return;
 			}
 
diff --git a/test/validator/samples/a11y-media-has-caption/input.svelte b/test/validator/samples/a11y-media-has-caption/input.svelte
index 6d98fd373448..813be0e750b7 100644
--- a/test/validator/samples/a11y-media-has-caption/input.svelte
+++ b/test/validator/samples/a11y-media-has-caption/input.svelte
@@ -1,4 +1,6 @@
 <video><track kind="captions"/></video>
+<video aria-hidden></video>
+<video aria-hidden="false"></video>
 <video></video>
 <video><track /></video>
 <audio></audio>

From cb42498c91f75b37a6bfa194d8ba31a9cc733a68 Mon Sep 17 00:00:00 2001
From: Carlos Ivanchuk <buhodev@proton.me>
Date: Sun, 6 Nov 2022 10:43:56 -0400
Subject: [PATCH 2/5] fix: move new <video> sample tests to the bottom

---
 test/validator/samples/a11y-media-has-caption/input.svelte | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/validator/samples/a11y-media-has-caption/input.svelte b/test/validator/samples/a11y-media-has-caption/input.svelte
index 813be0e750b7..8598caa9ad90 100644
--- a/test/validator/samples/a11y-media-has-caption/input.svelte
+++ b/test/validator/samples/a11y-media-has-caption/input.svelte
@@ -1,6 +1,6 @@
 <video><track kind="captions"/></video>
-<video aria-hidden></video>
-<video aria-hidden="false"></video>
 <video></video>
 <video><track /></video>
 <audio></audio>
+<video aria-hidden></video>
+<video aria-hidden="false"></video>

From cf1014f83a27b18a99fdf9f86e3889c7f9969474 Mon Sep 17 00:00:00 2001
From: Simon H <5968653+dummdidumm@users.noreply.github.com>
Date: Tue, 21 Feb 2023 15:49:31 +0100
Subject: [PATCH 3/5] Update src/compiler/compile/nodes/Element.ts

Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com>
---
 src/compiler/compile/nodes/Element.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/compiler/compile/nodes/Element.ts b/src/compiler/compile/nodes/Element.ts
index c2e1c0deb2e3..d6559008fc9d 100644
--- a/src/compiler/compile/nodes/Element.ts
+++ b/src/compiler/compile/nodes/Element.ts
@@ -713,7 +713,7 @@ export default class Element extends Node {
 			const aria_hidden_attribute = attribute_map.get('aria-hidden');
 			const aria_hidden_exist = aria_hidden_attribute && aria_hidden_attribute.get_static_value();
 
-			if (attribute_map.has('muted') || aria_hidden_exist) {
+			if (attribute_map.has('muted') || aria_hidden_exist === 'true')
 				return;
 			}
 

From 28eb945945b84eea34e73fe80bd2f40a4e290eef Mon Sep 17 00:00:00 2001
From: Simon H <5968653+dummdidumm@users.noreply.github.com>
Date: Tue, 21 Feb 2023 15:50:56 +0100
Subject: [PATCH 4/5] Update src/compiler/compile/nodes/Element.ts

---
 src/compiler/compile/nodes/Element.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/compiler/compile/nodes/Element.ts b/src/compiler/compile/nodes/Element.ts
index d6559008fc9d..d65c78a7aa87 100644
--- a/src/compiler/compile/nodes/Element.ts
+++ b/src/compiler/compile/nodes/Element.ts
@@ -713,7 +713,7 @@ export default class Element extends Node {
 			const aria_hidden_attribute = attribute_map.get('aria-hidden');
 			const aria_hidden_exist = aria_hidden_attribute && aria_hidden_attribute.get_static_value();
 
-			if (attribute_map.has('muted') || aria_hidden_exist === 'true')
+			if (attribute_map.has('muted') || aria_hidden_exist === 'true') {
 				return;
 			}
 

From ddea1e92ef7a654ea785b604951e6816f38c464c Mon Sep 17 00:00:00 2001
From: Simon H <5968653+dummdidumm@users.noreply.github.com>
Date: Tue, 21 Feb 2023 16:02:43 +0100
Subject: [PATCH 5/5] test

---
 .../a11y-media-has-caption/input.svelte       |  1 +
 .../a11y-media-has-caption/warnings.json      | 30 +++++++++++++++++++
 2 files changed, 31 insertions(+)

diff --git a/test/validator/samples/a11y-media-has-caption/input.svelte b/test/validator/samples/a11y-media-has-caption/input.svelte
index 8598caa9ad90..30f9a05f91ce 100644
--- a/test/validator/samples/a11y-media-has-caption/input.svelte
+++ b/test/validator/samples/a11y-media-has-caption/input.svelte
@@ -4,3 +4,4 @@
 <audio></audio>
 <video aria-hidden></video>
 <video aria-hidden="false"></video>
+<video aria-hidden="true"></video>
diff --git a/test/validator/samples/a11y-media-has-caption/warnings.json b/test/validator/samples/a11y-media-has-caption/warnings.json
index 72c2caae53f9..6db618f03cb0 100644
--- a/test/validator/samples/a11y-media-has-caption/warnings.json
+++ b/test/validator/samples/a11y-media-has-caption/warnings.json
@@ -28,5 +28,35 @@
       "column": 0,
       "line": 3
     }
+  },
+  {
+    "code": "a11y-media-has-caption",
+    "end": {
+      "character": 124,
+      "column": 27,
+      "line": 5
+    },
+    "message": "A11y: <video> elements must have a <track kind=\"captions\">",
+    "pos": 97,
+    "start": {
+      "character": 97,
+      "column": 0,
+      "line": 5
+    }
+  },
+  {
+    "code": "a11y-media-has-caption",
+    "end": {
+      "character": 160,
+      "column": 35,
+      "line": 6
+    },
+    "message": "A11y: <video> elements must have a <track kind=\"captions\">",
+    "pos": 125,
+    "start": {
+      "character": 125,
+      "column": 0,
+      "line": 6
+    }
   }
 ]