fix: svelte:element with dynamic this and spread attributes throws error #9112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1ef42c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gtm-nayan
reviewed
Aug 17, 2023
Contributor
gtm-nayan
left a comment
gtm-nayan
left a comment
There was a problem hiding this comment.
Can you add a runtime test, something similar to the reproduction in the issue.
Contributor
Author
|
Just add it. Thanks for the tip. |
gtm-nayan
reviewed
Aug 18, 2023
packages/svelte/src/compiler/compile/render_dom/wrappers/Element/index.js
Outdated
Show resolved
Hide resolved
…nt/index.js Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
gtm-nayan
approved these changes
Aug 19, 2023
Merged
kelvinsjk
pushed a commit
to kelvinsjk/svelte
that referenced
this pull request
Oct 19, 2023
…ror (sveltejs#9112) fixes sveltejs#9092 --------- Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9092
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint