This repository has been archived by the owner on Aug 3, 2021. It is now read-only.
Fix install:git, make:database, update:env commands #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenluijten
suggested changes
Jan 11, 2018
src/Commands/Databases/Make.php
Outdated
| @@ -27,6 +28,7 @@ public function configure() | |||
| ->addArgument('server', InputArgument::REQUIRED, 'The id of the server to create the database on.') | |||
| ->addOption('user', null, InputOption::VALUE_REQUIRED, 'The username of an (optional) database user to create.', null) | |||
| ->addOption('password', null, InputOption::VALUE_REQUIRED, 'The password of the database user. Required with "user".', null) | |||
| ->addOption('name', null, InputOption::VALUE_REQUIRED, 'The name of the database user.', null) | |||
There was a problem hiding this comment.
This is actually the name of the database to create, not the name of the database user 🙂
| /** | ||
| * @var array | ||
| */ | ||
| protected $optionMap = [ |
There was a problem hiding this comment.
Not required when the keys are the same as the values.
There was a problem hiding this comment.
fillData() returns an empty array in this case...
| /** | ||
| * @var array | ||
| */ | ||
| protected $optionMap = [ |
There was a problem hiding this comment.
Not required when the keys are the same as the values.
src/Commands/BaseCommand.php
Outdated
| @@ -87,7 +87,7 @@ protected function getFileContent(InputInterface $input, $option) | |||
| return $filename; | |||
| } | |||
|
|
|||
| if ($filename && ftell(STDIN) === 0) { | |||
| if ($filename && ftell(STDIN)) { | |||
There was a problem hiding this comment.
Why this? ftell() returns the position of the pointer. I'd be happy to use ftell(STDIN) !== false if you were looking for more type-safety here.
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add necessary
optionMapto some commands