Nuget dependency Cleanup #1071
Merged
Nuget dependency Cleanup #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eworks that don't need them
This reverts commit bdcedf5.
|
Seems I cannot change in this pull request the yml file for installing the .net core 3.1 sdk |
github-actions bot
pushed a commit
to H1Gdev/SVG
that referenced
this pull request
Aug 26, 2023
…UTING.md Generators Nuget README.md Samples Source Tests doc docfx.json index.md license.txt don't refererence System.Memory and System.ObjectModel in Target Frameworks that don't need them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't refererence System.Memory and System.ObjectModel in Target Frameworks that don't need them
What does this implement/fix? Explain your changes.
I saw that the nuget Package references System.Memory when it targets .NET 6, .NET Standard 2.1 this isn't necessary because the functionality is integrated in the .NET 6 Framework already.
only the Targets .NET Standard 2.0 and .NET 4.6.2 need it
I removed System.ObjectModel altogether because it is included in .NET Standard 2.0
Any other comments?