Remove Fizzler V3 #1092

inforithmics · 2023-09-09T14:29:31Z

Reference Issue

#1073

What does this implement/fix? Explain your changes.

remove Fizzler implements a QuerySelectAll that uses the ExCSS Selector Dom

Any other comments?

This pull request is based on this pull request
#1083

TODO:

A new Pull Request based on this.
#1086

Main Idea:
The idea is to Implement an IExCssSelectorOps Interface similar interface to IElementOps so that I can regression test to Fizzler Implementation. The ExCss Query tries to map the Selectors to the IExCssSelectorOps Interface, Because Fizzler has not implemented all Css Selectors certain Selectors are not implemented.

List of css selectors which should be supported.
https://stackoverflow.com/questions/42230563/what-is-the-compatibility-of-css3-pseudoclasses-with-svg-renderable-elements
All are handled (:target and :root in need to investigate)

inforithmics · 2023-09-09T14:29:51Z

I have enough Implemented for AngleSharp to run the Benchmark. here are the numbers (Maybe I need some more optimization)

Method	Mean	Error	StdDev	Op/s	Rank	Gen0	Gen1	Allocated
SelectorPerformanceExCss	5.188 us	0.0733 us	0.0685 us	192,739.3	1	2.6550	0.0153	21.7 KB
SelectorPerformanceFizzler	21.200 us	0.2856 us	0.2672 us	47,169.1	2	3.7537	-	30.9 KB
SelectorPerformanceAngleSharp	264.828 us	5.1335 us	5.7059 us	3,776.0	3	49.8047	2.9297	408.43 KB

There is certainly room for improvements in the AngleSharp Implementation. But I don't know if I can find there Factor 50.

nth-child(2) does not work yet need to make step and offset visible

inforithmics · 2023-09-16T19:31:06Z

Implmented N th Child and N th Last Child with reflection, if the Properties become public in excss than this refelction Code can be changed to Field, Property Access.

TylerBrinks/ExCSS#162

All Css Features that Fizzler supported are now supported. By the Excss Evalutor.

I test css selectors from AngeSharp so that the behave the same in Fizzler and excss.
Parse all svg documents and runt the css Selectors to test if they behave the same.
To reduce the number of dependencies I didn't further investigate the AngleSharp path.

H1Gdev · 2023-09-16T22:42:31Z

Source/Css/ExCssQuery.cs

+                TypeSelector typeSelector => ops.Type(typeSelector.Name),
+                UnknownSelector unknownSelector => throw new NotImplementedException(), // TODO:,
+                IdSelector idSelector => ops.Id(idSelector.Id),
+                _ => throw new NotImplementedException(), // TODO:,


TODO exists.

Removed the todos and add one more case that is not implemented. For the not typed selectors I have to look into excss what kind of selectors this is.

H1Gdev · 2023-09-16T22:44:11Z

Source/SvgDocument.cs

@@ -421,6 +462,7 @@ private static T Create<T>(XmlReader reader) where T : SvgDocument, new()
                            {
                                styles.Add(unknown);
                            }
+


remove this line.

…ler cannot evaluate them

H1Gdev · 2023-09-17T12:40:28Z

Source/Css/ExCssQuery.cs

+                AttrHyphenSelector attrHyphenSelector => ops.AttributeDashMatch(attrHyphenSelector.Attribute, attrHyphenSelector.Value),
+                AttrListSelector attrListSelector => ops.AttributeIncludes(attrListSelector.Attribute, attrListSelector.Value),
+                AttrMatchSelector attrMatchSelector => ops.AttributeExact(attrMatchSelector.Attribute, attrMatchSelector.Value),
+                AttrNotMatchSelector attrNotMatchSelector => ops.AttributeNotMatch(attrNotMatchSelector.Attribute, attrNotMatchSelector.Value), // TODO:,


TODO exists.

removed because it is now implemented

mrbean-bremen · 2023-09-21T18:09:29Z

From my perspective this looks quite good, but I'm not really qualified to review this. @wieslawsoltes and @H1Gdev - please check if this can be merged.

H1Gdev · 2023-09-30T02:48:49Z

@inforithmics
What is AngleSharp used for ?

inforithmics · 2023-09-30T19:10:19Z

Currently nothing, I used it for the Benchmarks. But when I saw that it was not very Performant I didn't continue investigating it. So I remove the AngleSharp Code from this pull request.

This reverts commit 8b7a228.

inforithmics · 2023-09-30T19:30:57Z

So I reduced the changes and removed AngleSharp Code

…eudofunction

inforithmics · 2023-10-01T07:12:13Z

I Implemented the :not Css Selector because in newest Fizzler 1.3.0 this was implemented (To keep feature parity).

inforithmics · 2023-10-01T07:18:47Z

Tests/Svg.UnitTests/Svg.UnitTests.csproj

@@ -36,11 +36,12 @@
  </ItemGroup>

  <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.3" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.11.0" />


16.8.3 has a security vulnerability so I upgraded to 16.11.0 to silence the warning.

inforithmics · 2023-10-01T07:19:05Z

Tests/Svg.UnitTests/Svg.UnitTests.csproj

    <PackageReference Include="NUnit" Version="3.13.0" />
    <PackageReference Include="NUnit3TestAdapter" Version="3.17.0" />
    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.0" PrivateAssets="All" />
    <PackageReference Include="Moq" Version="4.16.1" />
+    <PackageReference Include="Fizzler" Version="1.3.0" />


Upgraded to newest fizzler (for regression tests)

inforithmics · 2023-10-01T07:19:31Z

Tests/Svg.UnitTests/Css/SvgElementOps.cs

@@ -177,7 +177,7 @@ private IEnumerable<SvgElement> ElementsAfterSelf(SvgElement self)

        public Selector<SvgElement> NthLastChild(int a, int b)
        {
-            throw new NotImplementedException();


nlast child was not implemented previously is now implemented.

inforithmics · 2023-10-01T07:20:52Z

Source/Css/ExCssQuery.cs

+                {
+                    var sel = selector.Class.Substring(PseudoClassNames.Not.Length + 1, selector.Class.Length - 2 - PseudoClassNames.Not.Length);
+                    var parser = new StylesheetParser(true, true, tolerateInvalidValues: true);
+                    var styleSheet = parser.Parse(sel);


excss does not fully parse the not pseudofunc so I have to parse it myself here.

inforithmics · 2023-10-01T07:21:43Z

README.md

@@ -27,5 +27,4 @@ This project has dependencies on other open-source projects. These projects are

 |Project|Author|Sources|License|
 |--------|-----|---|---------|
-|Fizzler|Atif Aziz (@atifaziz)|[GitHub](https://github.com/atifaziz/Fizzler)|[LGPL](https://github.com/atifaziz/Fizzler/blob/master/COPYING.txt)|


is now removed from the nuget package as dependency is now only used as unit test dependency.

…tion was wrong for nth-child and nth-lastchild

…ators Nuget README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt initial ExCss Implementation ported from RemoveFizzlerV2 Branch BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt remove Fizzler from Readme BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt updated Fizzler for regression tests to 1.3.0 and implemented :not Pseudofunction BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt implemented nth type and nth-last-type BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt Implement :root

…d Generators Nuget README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt initial ExCss Implementation ported from RemoveFizzlerV2 Branch BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt remove Fizzler from Readme BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt updated Fizzler for regression tests to 1.3.0 and implemented :not Pseudofunction BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt implemented nth type and nth-last-type BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt Implement :root

Initial ExCss Implementation ported from RemoveFizzlerV2 Branch

1c7ce66

inforithmics mentioned this pull request Sep 9, 2023

Remove fizzler #1086

Closed

6 tasks

inforithmics added 3 commits September 9, 2023 16:37

fixing unit tests

6286583

add unit tests

8176a07

Added some more Selector Tests

d51a86b

nth-child(2) does not work yet need to make step and offset visible

inforithmics mentioned this pull request Sep 9, 2023

for evaluating nth-child(2) make step and offset visible TylerBrinks/ExCSS#162

Merged

inforithmics added 3 commits September 16, 2023 21:06

fixing unit tests

fd7b5cf

fixing build

9d96ecf

fixed unit tests

ea8b7b1

inforithmics marked this pull request as ready for review September 16, 2023 19:32

H1Gdev reviewed Sep 16, 2023

View reviewed changes

inforithmics added 5 commits September 17, 2023 11:09

done

82f9ea7

removed todos: and added one more case for not implementedexception

e4ac048

fixed naming

7339e24

added nth of type and nth-last-of-type tests are not run because fizz…

8ffee3d

…ler cannot evaluate them

implement nthlastchild in fizzler

d1c9ee5

H1Gdev reviewed Sep 17, 2023

View reviewed changes

Remove Fizzler from Readme

6613c74

inforithmics added 7 commits September 26, 2023 00:43

remove todo because it is now implemented

ae00a19

Anglesharp Initial

5a687ee

AngleSharp fixes

583a1c7

update excss (step and offset are now public)

484b3e5

disable AngleSharp

736588d

fixed compilation with anglesharp (disabled)

9d108ec

fixing tests

dfb7c60

inforithmics added 5 commits September 30, 2023 21:14

Remove Anglesharp

45c87e4

remove the specifiyed <SvgElement> for AngleSharp compilation

8b7a228

Revert "remove the specifiyed <SvgElement> for AngleSharp compilation"

4a43c78

This reverts commit 8b7a228.

reduce change for <svgelement> removal

83be12f

reduce changes

fa615ca

inforithmics added 2 commits September 30, 2023 23:45

parse not selector

48f01e1

Updated Fizzler for regression tests to 1.3.0 and implemented :not Ps…

c62458b

…eudofunction

inforithmics commented Oct 1, 2023

View reviewed changes

inforithmics added 6 commits October 1, 2023 09:23

removed nullable warning

1cb0ba0

spelling fixes

a2e4e6f

Ignore some not implemented Properties

e16ad81

fixed nth-child and nth-last-child implementation (fizzler implementa…

f6c5aa5

…tion was wrong for nth-child and nth-lastchild

imiplemented nth type and nth-last-type

3afdd58

Implement :root

09bfd20

H1Gdev approved these changes Oct 8, 2023

View reviewed changes

mrbean-bremen merged commit 1343b56 into svg-net:master Oct 9, 2023

inforithmics mentioned this pull request Oct 9, 2023

Fix loading of SvgImage Mapsui/Mapsui#2207

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove Fizzler V3 #1092

Remove Fizzler V3 #1092

inforithmics commented Sep 9, 2023 •

edited

Loading

inforithmics commented Sep 9, 2023

inforithmics commented Sep 16, 2023 •

edited

Loading

H1Gdev Sep 16, 2023

inforithmics Sep 17, 2023

H1Gdev Sep 16, 2023

inforithmics Sep 17, 2023

H1Gdev Sep 17, 2023

inforithmics Sep 25, 2023

mrbean-bremen commented Sep 21, 2023

H1Gdev commented Sep 30, 2023

inforithmics commented Sep 30, 2023

inforithmics commented Sep 30, 2023

inforithmics commented Oct 1, 2023 •

edited

Loading

inforithmics Oct 1, 2023

inforithmics Oct 1, 2023

inforithmics Oct 1, 2023

inforithmics Oct 1, 2023

inforithmics Oct 1, 2023

Remove Fizzler V3 #1092

Remove Fizzler V3 #1092

Conversation

inforithmics commented Sep 9, 2023 • edited Loading

Reference Issue

What does this implement/fix? Explain your changes.

Any other comments?

inforithmics commented Sep 9, 2023

inforithmics commented Sep 16, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrbean-bremen commented Sep 21, 2023

H1Gdev commented Sep 30, 2023

inforithmics commented Sep 30, 2023

inforithmics commented Sep 30, 2023

inforithmics commented Oct 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

inforithmics commented Sep 9, 2023 •

edited

Loading

inforithmics commented Sep 16, 2023 •

edited

Loading

inforithmics commented Oct 1, 2023 •

edited

Loading