Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use syntax injection for wikilink highlighting #560

Closed
memeplex opened this issue May 4, 2022 · 2 comments · Fixed by #561
Closed

Use syntax injection for wikilink highlighting #560

memeplex opened this issue May 4, 2022 · 2 comments · Fixed by #561

Comments

@memeplex
Copy link
Contributor

memeplex commented May 4, 2022

As described in #479 (comment):

  • Simpler declarative implementation (I think you can get rid of the entire syntaxDecorations.ts file)
  • Better performance
  • No flickering and weird intermediate colorization (see screenshot below)
  • Customizable color (using standard token highlighting settings)
  • Color appropriately changes with theme (sensible default that uses base link color)

image

@memeplex
Copy link
Contributor Author

You might be interested in primer/github-vscode-theme#320. I noticed that syntax injected wikilinks are not released yet and that wikilinks decorations are conflicting with such a popular theme may be a reason to push those changes.

@svsool
Copy link
Owner

svsool commented Jul 30, 2022

It should be released now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants