Update Ruff to 0.0.291 #3405
Merged
Update Ruff to 0.0.291 #3405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColonelPhantom
added
the
chore
github-actions
bot
added
app:mailinglists
DeD1rk
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff 0.0.291 is the newest version of Ruff, which adds some extra lints. Most of these can be fixed, except RUF012 which requires manual intervention. That said RUF012 is very 'extreme' in our codebase and is being discussed on the Ruff issue tracker as well: astral-sh/ruff#5243. So I'm ignoring it for now, but not sure if that is the way to go.
Summary
Updates ruff to 0.0.291
How to test
Should be functionally equivalent!