feat: change logging of scripts bootstrap

swashata · Oct 13, 2018 · 7bb89b6 · 7bb89b6
1 parent e1f0a65
commit 7bb89b6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 14 deletions.
diff --git a/examples/theme/package.json b/examples/theme/package.json
@@ -12,9 +12,7 @@
   "scripts": {
     "bootstrap": "wpackio-scripts bootstrap",
     "exbuild": "wpackio-scripts build",
-    "exstart": "wpackio-scripts start",
-    "build": "wpackio-scripts build",
-    "start": "wpackio-scripts start"
+    "exstart": "wpackio-scripts start"
   },
   "dependencies": {
     "@wpackio/scripts": "^0.0.3"

diff --git a/packages/scripts/src/bin/bootstrap.ts b/packages/scripts/src/bin/bootstrap.ts
@@ -60,9 +60,7 @@ export async function bootstrap(
 			const spinner = ora({ spinner: 'dots3' });
 
 			if (done.deps && done.deps.dependencies.length) {
-				console.log(
-					`${logSymbols.info} need to install following dependencies`
-				);
+				console.log(`🍪 need to install following dependencies\n`);
 				console.log(
 					`    ${bulletSymbol} ${chalk.yellow(
 						done.deps.dependencies.join(', ')
@@ -72,14 +70,10 @@ export async function bootstrap(
 					`installing dependencies${watchEllipsis} may take a while`
 				);
 				await execa(command, [add, ...done.deps.dependencies]);
-				spinner.succeed('done installing dependencies');
+				spinner.succeed('done installing dependencies\n');
 			}
 			if (done.deps && done.deps.devDependencies.length) {
-				console.log(
-					`️${
-						logSymbols.info
-					} need to install following dev dependencies\n`
-				);
+				console.log(`⚙️ need to install following dev dependencies\n`);
 				console.log(
 					`    ${bulletSymbol} ${chalk.green(
 						done.deps.devDependencies.join(', ')
@@ -94,7 +88,7 @@ export async function bootstrap(
 					devParam,
 				]);
 
-				spinner.succeed('done installing dependencies');
+				spinner.succeed('done installing dependencies\n');
 			}
 		} catch (e) {
 			console.log(

diff --git a/packages/scripts/src/scripts/Bootstrap.ts b/packages/scripts/src/scripts/Bootstrap.ts
@@ -267,7 +267,7 @@ export class Bootstrap {
 			? // tslint:disable-next-line:non-literal-require
 			  require(this.packageJsonPath)
 			: {
-					name: '',
+					name: projectContext.appName,
 			  };
 		// Check if script is already present
 		const scripts: { [x: string]: string } = {