feat(es/typescript): inline enum #3647
Conversation
|
Does this fix #940? |
magic-akari
force-pushed
the
feat/enum-inline
branch
from
5274af9 to
7bda1d7
Compare
|
Partially. |
|
|
||
| impl Default for InlineEnumConfig { | ||
| fn default() -> Self { | ||
| Self::All(true) |
There was a problem hiding this comment.
@kdy1
I set "inline all as possible" as default option.
What do you think about it?
There was a problem hiding this comment.
I think it's good enough to be default
There was a problem hiding this comment.
There is a risk to make it default.
See https://www.typescriptlang.org/play?#code/KYOwrgtgBAglDeAoKsA0UBCiC+jEAo4BDAZyiJAE8BKAbQHIZ6BdKAXigEYBuA4sijVoAGVh06IgA
| use swc_ecma_utils::ident::IdentLike; | ||
| use swc_ecma_visit::{as_folder, noop_visit_mut_type, Fold, VisitMut, VisitMutWith}; | ||
|
|
||
| pub type TSEnumLit = Rc<RefCell<AHashMap<Id, AHashMap<JsWord, Lit>>>>; |
There was a problem hiding this comment.
Can you change this to a struct which hides the actual type?
The field can be like
pub(crate) values: Rc<RefCell<AHashMap<Id, AHashMap<JsWord, Lit>>>>|
|
||
| impl Default for InlineEnumConfig { | ||
| fn default() -> Self { | ||
| Self::All(true) |
There was a problem hiding this comment.
If so, we have two options I guess.
The first one is adding a field to Assumptions and the second one is defaulting to EnumConst::Const.
I think the second one would be better at the moment
There was a problem hiding this comment.
I prefer an assumption, we need to expose Assumptions in a near future anyway.
There was a problem hiding this comment.
Oh, I see. I think the assumption is good too.
There was a problem hiding this comment.
That would also need to change the options from InlineEnumConfig to bool
magic-akari
force-pushed
the
feat/enum-inline
branch
from
a5d46a5 to
66f3668
Compare
| is_lhs: bool, | ||
| } | ||
|
|
||
| trait SkipInlineEnum { |
| fn skip(&self) -> bool; | ||
| } | ||
|
|
||
| impl SkipInlineEnum for InlineEnum { |
There was a problem hiding this comment.
Seems like this is the only impl.
I think it can be a method of InlineEnum
There was a problem hiding this comment.
I had implemented this method on another pub struct while I want to hide it, so I wrote this trait.
I am going to fix it.
|
|
||
| pub(crate) type TSEnumLit = Rc<RefCell<AHashMap<Id, AHashMap<JsWord, Lit>>>>; | ||
|
|
||
| pub fn inline_enum(ts_enum_lit: TSEnumLit, ts_enum_config: TSEnumConfig) -> impl Fold + VisitMut { |
There was a problem hiding this comment.
This function is exposing a crate-local type (TSEnumLit) in public api.
There was a problem hiding this comment.
Yes, inline_enum should not be public API
magic-akari
force-pushed
the
feat/enum-inline
branch
from
99d6514 to
f69f138
Compare
Description:
Inline enum if possible.
BREAKING CHANGE:
Related issue (if exists):