Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(swc/transform_module): fix local scoped amd require #4800

Merged
merged 4 commits into from
May 25, 2022
Merged

fix(swc/transform_module): fix local scoped amd require #4800

merged 4 commits into from
May 25, 2022
+69 −32

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented May 25, 2022 •
edited by kdy1
Loading

  • fix(swc/transform_module): preserve local scoped require ident
  • fix(swc/transform_module): loosen local require insert rule

Description:

Attempt to cover few more cases for the local scoped require for amd. Allows to detect require usage other than call itself (require can be passed as ref), as well as loosen insertion rules other than having export.

BREAKING CHANGE:

Related issue (if exists):

kdy1
kdy1 approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_ecma_transforms_module

@kdy1 kdy1 added this to the Planned milestone May 25, 2022
@kdy1 kdy1 enabled auto-merge (squash) May 25, 2022 17:08
swc-bot
swc-bot reviewed May 25, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed May 25, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 2b03047 into swc-project:main May 25, 2022
@kwonoj kwonoj mentioned this pull request May 25, 2022
Closed
15 tasks
@kdy1 kdy1 modified the milestones: Planned, v1.2.195 May 26, 2022
@kwonoj kwonoj deleted the fix-amd-local-scoped-require branch June 29, 2022 00:23
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.195
Development

Successfully merging this pull request may close these issues.

Local AMD require call sometimes missing Local AMD require function not always called require
3 participants
@kwonoj @kdy1 @swc-bot