fix(es/codegen): Emit question token for class methods #9342
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ff6aa78 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dsherret
commented
Jul 29, 2024
| @@ -1599,6 +1599,10 @@ where | |||
| } | |||
| } | |||
|
|
|||
| if n.is_optional { | |||
| punct!("?"); | |||
| } | |||
There was a problem hiding this comment.
I think this regressed because previously it happened to emit from the binding ident being optional.
CodSpeed Performance ReportMerging #9342 will improve performances by 3.39%Comparing Summary
Benchmarks breakdown
|
magic-akari
previously approved these changes
Jul 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the process of upgrading swc and stumbled on this one.
Description: Regression in emitting class methods that are optional.
Related issue (if exists): None