Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UDP logger for SBP #173

Merged
merged 3 commits into from
Jun 19, 2015
Merged

UDP logger for SBP #173

merged 3 commits into from
Jun 19, 2015

Conversation

mfine
Copy link
Contributor

@mfine mfine commented Jun 19, 2015

A simple UDP logger. Sends messages over a UDP address:port pair. There should be some library help around framing out the message instead of doing it explicitly here. Haven't tried this out yet.

/cc @fnoble @denniszollo

@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/142/
Test PASSed.

@mfine mfine mentioned this pull request Jun 19, 2015
Merged
@fnoble
Copy link
Contributor

fnoble commented Jun 19, 2015

lgtm, @mookerji suggested adding a unit test before like this: https://github.com/swift-nav/pySTR4500/blob/master/test/test_client.py.

denniszollo
denniszollo reviewed Jun 19, 2015
View reviewed changes
python/sbp/client/examples/udp.py
@@ -15,9 +15,8 @@

from sbp.client.drivers.pyserial_driver import PySerialDriver
from sbp.client.handler import Handler
from sbp.client.loggers import UdpLogger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to work? The file is named udp_logger...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yea, should be

from sbp.client.loggers.udp_logger import UdpLogger

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we should make the file executable.

@swiftnav-jenkins
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/147/
Test PASSed.

@mfine
Copy link
Contributor Author

mfine commented Jun 19, 2015

Going to bring this in for integration. Will finish the test in a later PR.

mfine added a commit that referenced this pull request Jun 19, 2015
@mfine
Merge pull request #173 from mfine/mfine-udp-logger
8de7e49 
UDP logger for SBP
@mfine mfine merged commit 8de7e49 into swift-nav:master Jun 19, 2015
@mfine mfine deleted the mfine-udp-logger branch June 19, 2015 19:29
woodfell added a commit that referenced this pull request Apr 29, 2024
@swiftnav-svc-jenkins @woodfell
Auto submodule update: cmake - enable c++20 (#173) (#1411)
9913052 
Automated PR by Jenkins. If CI has passed successfully, merge away!



**cmake**  f5113f7d  ->  117b3f73
-  117b3f73  :  enable c++20 (swift-nav/cmake#173)
-  436d339a  :  Handle new suitesparse version (swift-nav/cmake#171)


This pull request was created by
https://jenkins.ci.swift-nav.com/job/CI%20Infra/job/submodule-update/17095/.

Co-authored-by: Matt Woodward <46688854+woodfell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mfine mfine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfine @swiftnav-jenkins @fnoble @denniszollo