From 3a9e4fffb1d3c7b9f62cde5a44efdd30f8c3a41b Mon Sep 17 00:00:00 2001 From: Fred Riss Date: Mon, 4 Nov 2019 09:41:48 -0800 Subject: [PATCH 1/2] Add missing codesign step for on-device testing (cherry picked from commit a9d25c9d5322223aeb04e26dbfa5c58ca90e1652) --- lldb/packages/Python/lldbsuite/test/make/Makefile.rules | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules index 004807d34fe66..9734edfd79a39 100644 --- a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules +++ b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules @@ -793,6 +793,9 @@ ifneq "$(EXCLUDE_WRAPPED_SWIFTMODULE)" "" else $(SWIFTC) $(patsubst -g,,$(SWIFTFLAGS)) -emit-library $(DYLIB_SWIFT_FLAGS) -o $@ $^ endif +ifneq "$(CODESIGN)" "" + $(CODESIGN) -s - "$(DYLIB_FILENAME)" +endif ifneq "$(MAKE_DSYM)" "NO" ifneq "$(DS)" "" "$(DS)" $(DSFLAGS) "$(DYLIB_FILENAME)" From c15b2f21bf10a901243d9aab625adaa23c01d445 Mon Sep 17 00:00:00 2001 From: Fred Riss Date: Mon, 4 Nov 2019 09:42:13 -0800 Subject: [PATCH 2/2] Allow playground tests to run on device (cherry picked from commit da93bc5cc1cd18cd1165213e7e7c87a06500941f) --- lldb/packages/Python/lldbsuite/test/lldbplaygroundrepl.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lldb/packages/Python/lldbsuite/test/lldbplaygroundrepl.py b/lldb/packages/Python/lldbsuite/test/lldbplaygroundrepl.py index fa369f8839a57..b3238f5025a26 100644 --- a/lldb/packages/Python/lldbsuite/test/lldbplaygroundrepl.py +++ b/lldb/packages/Python/lldbsuite/test/lldbplaygroundrepl.py @@ -56,6 +56,8 @@ def repl_set_up(self): target = self.dbg.CreateTarget(exe) self.assertTrue(target, VALID_TARGET) + self.registerSharedLibrariesWithTarget(target, ['libPlaygroundsRuntime.dylib']) + # Set the breakpoints breakpoint = target.BreakpointCreateBySourceRegex( 'Set breakpoint here', self.PlaygroundStub_source_spec)