Modify assertLint test helper to run via pipeline only. #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes me wonder if we even need the standalone-run mode anymore. Since we now double-check everything using the pipeline, it might be better to just have that be the single mode we care about, because the rule never runs in a standalone mode otherwise. Could you make that change instead? Then test authors don't have to pick what mode they're interested in, which is cleaner. |
|
Sure! From my point of view that's better -- I found it pretty confusing when I was getting different behavior between the two runs. |
Standalone lint visitors don't check for swift-format-ignore markers, so any test cases that use those markers will return different results between standalone vs full pipeline. Since the app uses the pipeline only, there is no value in running the rule standalone.
shawnhyam
force-pushed
the
swift-format-ignore
branch
from
2588749
to
01ac894
Compare
shawnhyam
changed the title
allevato
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standalone lint visitors don't check for swift-format-ignore markers, so any test cases that use those markers will return different results between standalone vs full pipeline.